Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:77239 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 47287 invoked from network); 16 Sep 2014 09:23:55 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 16 Sep 2014 09:23:55 -0000 Authentication-Results: pb1.pair.com header.from=ajf@ajf.me; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=ajf@ajf.me; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ajf.me designates 192.64.116.208 as permitted sender) X-PHP-List-Original-Sender: ajf@ajf.me X-Host-Fingerprint: 192.64.116.208 imap2-3.ox.privateemail.com Received: from [192.64.116.208] ([192.64.116.208:43731] helo=imap2-3.ox.privateemail.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 7A/7B-64534-AA108145 for ; Tue, 16 Sep 2014 05:23:54 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.privateemail.com (Postfix) with ESMTP id 525AD8C0080; Tue, 16 Sep 2014 05:23:51 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at imap2.ox.privateemail.com Received: from mail.privateemail.com ([127.0.0.1]) by localhost (imap2.ox.privateemail.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id HtMLHQoaXUGm; Tue, 16 Sep 2014 05:23:51 -0400 (EDT) Received: from oa-res-27-90.wireless.abdn.ac.uk (oa-res-27-90.wireless.abdn.ac.uk [137.50.27.90]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.privateemail.com (Postfix) with ESMTPSA id 7514C8C007B; Tue, 16 Sep 2014 05:23:48 -0400 (EDT) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) In-Reply-To: Date: Tue, 16 Sep 2014 10:23:46 +0100 Cc: Levi Morrison , PHP Developers Mailing List Content-Transfer-Encoding: quoted-printable Message-ID: <93C6A290-493F-42B3-824B-AE81ACCDBA61@ajf.me> References: <528B8D9E-58FF-47DD-9B91-013F8844EC70@ajf.me> To: Dmitry Stogov X-Mailer: Apple Mail (2.1878.6) Subject: Re: [PHP-DEV] [VOTE][RFC] Integer Semantics From: ajf@ajf.me (Andrea Faulds) On 16 Sep 2014, at 10:16, Dmitry Stogov wrote: > Shifts by negative number may make sense. (N << -1) =3D> (N >> 1) > At least receiving "false" from shift is not very pleasant. The problem is that changing from the current behaviour (undefined in C, = but typically a shift by (PHP_INT_MAX - $bits)) to do what you=92d = expect (shift in the opposite direction) would be a silent BC break. I = think it=92s better to just stop it altogether and raise an E_WARNING, = where it=92s at least obvious something went wrong, than change this = behaviour silently. > In the patch you use SIZEOF_LONG. It probably should be changed to > SIZEOF_ZEND_LONG. Will fix, thanks for spotting that. -- Andrea Faulds http://ajf.me/