Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:77208
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.45 as permitted sender)
MIME-Version: 1.0
Sender: mike.php.net@gmail.com
In-Reply-To: <CAMbn9ZHwvK2mo9ubnAF+TNiv9Oto_PpFDN9_E87Rs4wi3kXJow@mail.gmail.com>
References: <CALJZF3hXcsFiShTeOj5LjGEeUwO2TgiAiGT_OPJW3owjhQ-K5w@mail.gmail.com>
	<CAESVnVqwL-3-n-ZMxnmCJ=u9z0CO1Lm9ZmSuV62OTy_kajSJ3Q@mail.gmail.com>
	<05091D9021CD48208FCE220DE1CCC3CE@pc07654>
	<53BD9F71.1090401@sugarcrm.com>
	<541029AF.6080000@php.net>
	<CAMbn9ZHwvK2mo9ubnAF+TNiv9Oto_PpFDN9_E87Rs4wi3kXJow@mail.gmail.com>
Date: Mon, 15 Sep 2014 06:44:53 +0200
Message-ID: <CALJZF3hdtWiqDsTxd518RAgdF819P10Me4U-ZXzv86hK22_z-g@mail.gmail.com>
To: Matt F <themattficken@gmail.com>
Cc: PHP Internals <internals@lists.php.net>, Sara Golemon <pollita@php.net>, 
	Stas Malyshev <smalyshev@sugarcrm.com>, Nuno Lopes <nlopess@php.net>
Content-Type: multipart/alternative; boundary=089e0158c31ac56d240503134b82
Subject: Re: [PHP-DEV] Concurrency support for run-tests
From: mike@php.net (Michael Wallner)

--089e0158c31ac56d240503134b82
Content-Type: text/plain; charset=UTF-8

On 15 Sep 2014 05:59, "Matt Ficken" <themattficken@gmail.com> wrote:

>
> In making/merging major changes (like concurrency) the most important
thing is to not break that compatibility and dependability:
>
> Your patch will fail without the /proc filesystem(mac osx?). On Windows,
you can check the %NUMBER_OF_PROCESSORS% environment variable. For unices
that don't have /proc there may not be a single simple way to check.

It won't "fail", it just wouldn't enable reasonable concurrency by default.
But auto-enabling concurrency is out of question now anyway.

While the patch looks big,  most of it is caused by indentation, because
some code was converted to a callback.

>
> For more speed, rather than grouping all, fe open_basedir tests into a
single `Concurrency Group` its better to have them all operate in separate
temporary directories and database tables (then you could run 32 or 64
openbase dir tests at once).

Sure,  I tried to unfuck the open_basedir tests, but failed once.

Ps: Have to look at PFTT yet.

--089e0158c31ac56d240503134b82--