Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:77134
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.47 as permitted sender)
MIME-Version: 1.0
Sender: are.you.winning@gmail.com
In-Reply-To: <BAE9FD60-A646-4416-AB73-3A5D2015859C@gmail.com>
References: <BAE9FD60-A646-4416-AB73-3A5D2015859C@gmail.com>
Date: Wed, 10 Sep 2014 10:20:47 +0100
Message-ID: <CAGAGxbYL4cF41iyMf2YvfJC6yPR-+uXaTUT3HjWE+2UB8daidg@mail.gmail.com>
To: Tjerk Meesters <tjerk.meesters@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Deprecated functions
From: cw@daverandom.com (Chris Wright)

On 10 September 2014 06:42, Tjerk Meesters <tjerk.meesters@gmail.com> wrote=
:
> Hi,
>
> When I was fixing test cases on my `kill-ereg` branch I noticed a Reflect=
ion test case for `ReflectionFunction::isDeprecated()`.
>
> The problem with such a test case is that you=E2=80=99d be chasing deprec=
ated functions to tests against as we move along; this is the current list =
of deprecated functions as taken from a typical 5.4 installation:
>
> Since 4.1.0: call_user_method, call_user_method_array
> Since 4.3.7: mysql_list_tables, mysql_listtables
> Since 5.3  : ereg, ereg_replace, eregi, eregi_replace, split, spliti, sql=
_regcase, mysql_db_query, magic_quotes_runtime, set_magic_quotes_runtime, s=
et_socket_blocking
> Since 5.4  : mysql_list_dbs
>
> The above are, as far as I=E2=80=99m concerned, all potential candidates =
for removal in PHP 7, so in order to reliably test a deprecated function I =
would suggest introducing a hidden function with this signature:
>
> void __deprecated__() { }
>
> And mark that function as eternally deprecated using the ZEND_ACC_DEPRECA=
TED flag.
>
> Thoughts?

An alternative could be this:

--FILE--
<?php

error_reporting(E_DEPRECATED);

foreach (get_defined_functions()['internal'] as $func) {
    $ref =3D new \ReflectionFunction($func);

    if ($ref->isDeprecated()) {
        $func();
        break;
    }
}

?>
--EXPECTF--

Deprecated: Function %s() is deprecated in %s on line %d


...although arguably this is testing the error rather than the
reflection function. This also assumes that there will always be at
least one deprecated function in the standard library, although I
doubt this is likely to be an issue any time soon.