Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:77131
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.50 as permitted sender)
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
In-Reply-To: <CAEbg-4aVJBbm-_B5rz8ou7ifEPWhAq6RVKVDsvAMkKzQ6OsATg@mail.gmail.com>
Date: Wed, 10 Sep 2014 15:14:01 +0800
Cc: PHP Internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <7CFC622E-E0FF-40F6-8EA4-CCC4C20608A7@gmail.com>
References: <BAE9FD60-A646-4416-AB73-3A5D2015859C@gmail.com> <CAEbg-4aVJBbm-_B5rz8ou7ifEPWhAq6RVKVDsvAMkKzQ6OsATg@mail.gmail.com>
To: Alexander Lisachenko <lisachenko.it@gmail.com>
Subject: Re: [PHP-DEV] Deprecated functions
From: tjerk.meesters@gmail.com (Tjerk Meesters)

Hi Alex,

On 10 Sep 2014, at 13:59, Alexander Lisachenko <lisachenko.it@gmail.com> =
wrote:

> Hi!
>=20
> Maybe it will be better to do this in another way: introduce an RFC to
> add 'deprecated' keyword into the syntax like 'final' or 'protected'.
> There are many frameworks that want to deprecate some methods or
> classes. Currently it's only possible via "@deprecated" tag in the
> phpDoc-block, but this tag doesn't influence on method invocation, so
> no warnings are generated.

Any decent IDE should tell you that a function is deprecated by =
observing DocBlock; I believe PhpStorm uses strike-through to indicate =
deprecated functionality.

>=20
> Symfony uses trigger_error($message, E_USER_DEPRECATED) explicitly in
> deprecated methods to trigger this warning (see
> https://github.com/symfony/symfony/pull/6180), but this is not a
> transparent solution.

I agree that having a =91deprecated=92 keyword would simplify matters, =
but I don=92t think that alone is worth making it a language feature.

This could be a good case for annotations, though, if we ever get such a =
thing :)

>=20
> This can be look like this:
>=20
> class Test {
>    deprecated protected $someProperty;
>=20
>    deprecated public function foo() {}
>    public function bar() {}
> }
>=20
>=20
> deprecated class OldStuff {}
>=20
> deprecated function someOldFunction() {}
>=20
> This RFC will give more control over 'deprecated' functionality and
> can be easily tested.
>=20
> Thoughts?
>=20
> 2014-09-10 9:42 GMT+04:00 Tjerk Meesters <tjerk.meesters@gmail.com>:
>> Hi,
>>=20
>> When I was fixing test cases on my `kill-ereg` branch I noticed a =
Reflection test case for `ReflectionFunction::isDeprecated()`.
>>=20
>> The problem with such a test case is that you=92d be chasing =
deprecated functions to tests against as we move along; this is the =
current list of deprecated functions as taken from a typical 5.4 =
installation:
>>=20
>> Since 4.1.0: call_user_method, call_user_method_array
>> Since 4.3.7: mysql_list_tables, mysql_listtables
>> Since 5.3  : ereg, ereg_replace, eregi, eregi_replace, split, spliti, =
sql_regcase, mysql_db_query, magic_quotes_runtime, =
set_magic_quotes_runtime, set_socket_blocking
>> Since 5.4  : mysql_list_dbs
>>=20
>> The above are, as far as I=92m concerned, all potential candidates =
for removal in PHP 7, so in order to reliably test a deprecated function =
I would suggest introducing a hidden function with this signature:
>>=20
>> void __deprecated__() { }
>>=20
>> And mark that function as eternally deprecated using the =
ZEND_ACC_DEPRECATED flag.
>>=20
>> Thoughts?