Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:77111
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain basereality.com from 74.125.82.46 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAHMUw2HVmJD9syo8Rbc1=bA5S3U9umS0_XHFzwzWsY9Ee7UneQ@mail.gmail.com>
References: <CABRjmp_2DzhrGGoknZvSZ6fM=okjz+Od+2t0TVrNarc2fRLWiA@mail.gmail.com>
	<CAHMUw2HVmJD9syo8Rbc1=bA5S3U9umS0_XHFzwzWsY9Ee7UneQ@mail.gmail.com>
Date: Tue, 9 Sep 2014 15:10:27 +0100
Message-ID: <CA+kxMuRiRu_hS1t3N40PeCsg6DhrEz_4uGh+fNqT+TP62w9zVw@mail.gmail.com>
To: Tjerk Meesters <tjerk.meesters@gmail.com>
Cc: Florian Margaine <florian@margaine.com>, PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] setcookie() minor BC break - fixes issue #67736
From: danack@basereality.com (Dan Ackroyd)

> How about delaying that warning until the headers are sent?

I don't think there would be any benefit to that. The only possible
scenarios are:

i) People sending duplicate headers by accident. When they see the
error, they should fix their code, so the error goes away.

ii) People who are deliberately sending duplicate headers (e.g. for a
custom client that requires them). They will be suppressing the error
and so it won't be seen anywhere.

As I said in the PR, the current behaviour isn't a PHP bug, it's doing
exactly what it was told to do by callee.

Changing the behaviour of setcookie to 'guess' what the programmer
really meant would definitely be wrong, and I'm not sure that giving a
warning is all that helpful either.

cheers
Dan


On 8 September 2014 07:50, Tjerk Meesters <tjerk.meesters@gmail.com> wrote:
> Hi!
>
>
> On Sat, Sep 6, 2014 at 5:38 AM, Florian Margaine <florian@margaine.com>
> wrote:
>
>> Hi,
>>
>> This is a minor BC break, but still a BC break, so worth discussing on this
>> ML.
>>
>> When a second setcookie() is done with the same name, a warning is emitted,
>> because the ietf rfc 6265 says it *should* only send one Set-Cookie header
>> per name.
>>
>> This is fine when display_errors is set to off. When it's set to on, the
>> warning prevents the header from being added because "headers already sent"
>> (which is the minor BC break, as current PHP just sends 2 Set-Cookie
>> headers with the same name).
>>
>
> Yeah, it would prevent any header() or setcookie() following that warning
> from taking place.
>
> How about delaying that warning until the headers are sent?
>
>
>>
>> So, should it be merged? What should be done to comply with the ietf rfc
>> 6265?
>>
>> PR: https://github.com/php/php-src/pull/795/
>> PHP issue: https://bugs.php.net/bug.php?id=67736
>>
>> Regards,
>>
>> *Florian Margaine*
>>
>
>
>
> --
> --
> Tjerk