Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:77110 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 12293 invoked from network); 9 Sep 2014 10:31:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 Sep 2014 10:31:50 -0000 Authentication-Results: pb1.pair.com smtp.mail=nikita.ppv@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=nikita.ppv@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.53 as permitted sender) X-PHP-List-Original-Sender: nikita.ppv@gmail.com X-Host-Fingerprint: 209.85.215.53 mail-la0-f53.google.com Received: from [209.85.215.53] ([209.85.215.53:40938] helo=mail-la0-f53.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F6/70-08634-417DE045 for ; Tue, 09 Sep 2014 06:31:50 -0400 Received: by mail-la0-f53.google.com with SMTP id ge10so1595408lab.26 for ; Tue, 09 Sep 2014 03:31:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=pN5RRsYR+n/05MjGk53Yvj1UWEbcv3M5izey6B8Z/s8=; b=J/L8w+tSgD7ZB63xtB0GzEUfS4NcGSON5ewqo3JPblKRGeWGG2rqrhRIPo4+yL50tr Cn5XQcCjKIyY5saRmp062i+PhMOMG2KIe4B8leaJO1eNwMij4O0WoEWonNJJVIf/MsXO dfkSoK6+Djz/sAGdV9lN0g2clj01KKaDTHaZgDsOWWg9XlSzHP7ZNyABrtohz1sn/X1r owMpbnZsu/xo2E/qp2SbLKZ60SMUzHt+i2hG+o3xrNaQgeDQ3ENIMmKUJPsVmBWEL59a 6iM0vyDs1o/9YTT3NbjP1FLxAtCVtcmWHmxDIb4oJGhqDRNhvSap4j1ojqvkQL9O5n6p vgig== MIME-Version: 1.0 X-Received: by 10.112.28.8 with SMTP id x8mr1456017lbg.104.1410258704962; Tue, 09 Sep 2014 03:31:44 -0700 (PDT) Received: by 10.25.218.204 with HTTP; Tue, 9 Sep 2014 03:31:44 -0700 (PDT) In-Reply-To: References: Date: Tue, 9 Sep 2014 12:31:44 +0200 Message-ID: To: Dmitry Stogov Cc: PHP Internals Content-Type: multipart/alternative; boundary=001a11340428269a7905029f7198 Subject: Re: Memory corruptions related to AST patch From: nikita.ppv@gmail.com (Nikita Popov) --001a11340428269a7905029f7198 Content-Type: text/plain; charset=UTF-8 On Mon, Sep 8, 2014 at 9:26 AM, Dmitry Stogov wrote: > Hi Nikita, > > On weekend I ran PHP test suite with valgrind and opcache. > I noticed few new tests failures, that most probably introduced by AST > patch. > > Bug #21820 ("$arr['foo']" generates bogus E_NOTICE, should be E_PARSE) > [tests/lang/bug21820.phpt] > Bug #66286: Incorrect object comparison with inheritance > [Zend/tests/bug66286.phpt] > unbraced complex variable replacement test (heredoc) > [Zend/tests/heredoc_005.phpt] > isset() can be used on dereferences of temporary expressions > [Zend/tests/varSyntax/issetOnTemp.phpt] > > I suppose they indicate two different problems. > One of them indicates that some zvals became a subject for GC, however > they won't before. This may be fixed in opcache, but it's better to > understand what was changed. > > Please take a look. > > Thanks. Dmitry. > For the record, these have been resolved by https://github.com/php/php-src/commit/af84d5737c47c3ec3959e056f171b14ab76fb7b8 and https://github.com/php/php-src/commit/c59300ac86dd02bcdacd6c1460a5b43e91a5bf49 . Nikita --001a11340428269a7905029f7198--