Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:77100
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.51 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAL+t6cEfbd7KbB=EbhdqgLKG6tBURgj+Ls9Y62tjOHL1Y+r-SA@mail.gmail.com>
References: <CABRjmp_2DzhrGGoknZvSZ6fM=okjz+Od+2t0TVrNarc2fRLWiA@mail.gmail.com>
	<CAHMUw2HVmJD9syo8Rbc1=bA5S3U9umS0_XHFzwzWsY9Ee7UneQ@mail.gmail.com>
	<CAL+t6cEfbd7KbB=EbhdqgLKG6tBURgj+Ls9Y62tjOHL1Y+r-SA@mail.gmail.com>
Date: Mon, 8 Sep 2014 10:09:12 +0200
Message-ID: <CAH-PCH7tDQCtmAbPNOF4ONkeSQz5wr89XJ81a0USmzCqKi=26g@mail.gmail.com>
To: Sherif Ramadan <theanomaly.is@gmail.com>
Cc: Tjerk Meesters <tjerk.meesters@gmail.com>, Florian Margaine <florian@margaine.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1133979e922aa7050289556c
Subject: Re: [PHP-DEV] setcookie() minor BC break - fixes issue #67736
From: tyra3l@gmail.com (Ferenc Kovacs)

--001a1133979e922aa7050289556c
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 8, 2014 at 9:15 AM, Sherif Ramadan <theanomaly.is@gmail.com>
wrote:

> Actually, we shouldn't be doing that all. We should simply just overwrite
> the header. It wouldn't make much sense to set two headers with the same
> cookie name when we can just overwrite it.
>
>
>
that would be a bigger BC break, and without a warning, those people
affected by the change will have a harder time figuring out what went wrong=
.
and as was discussed both in the PR and the bugreport the rfc discourages
but doesn't prohibit this behavior, so making it impossible for the
userland to do it would be a bit of an arbitrary restriction.
maybe we could do something like introducing a new $overwrite =3D true opti=
on
to the function signature, but setcookie already has 7 arguments, so
probably isn't a great idea.

--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu

--001a1133979e922aa7050289556c--