Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:77099
Return-Path: <mike.php.net@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 13567 invoked from network); 8 Sep 2014 08:08:19 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 8 Sep 2014 08:08:19 -0000
Authentication-Results: pb1.pair.com header.from=mike.php.net@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=mike.php.net@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.182 as permitted sender)
X-PHP-List-Original-Sender: mike.php.net@gmail.com
X-Host-Fingerprint: 74.125.82.182 mail-we0-f182.google.com  
Received: from [74.125.82.182] ([74.125.82.182:42499] helo=mail-we0-f182.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id D2/C2-26504-2F36D045 for <internals@lists.php.net>; Mon, 08 Sep 2014 04:08:19 -0400
Received: by mail-we0-f182.google.com with SMTP id w62so14481535wes.13
        for <internals@lists.php.net>; Mon, 08 Sep 2014 01:08:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject
         :references:in-reply-to:content-type:content-transfer-encoding;
        bh=8pXY88+W0j03En194hCSDsTag1v/RbJ4I+/NLYbHn88=;
        b=StwbhjXVdproB4u/xGOhJnLVxupB3pYFinoEGspH+EREQHS61zcswMeEld7awQC/wg
         KWpMGLZBeqnX3YSaXsyMydFB3YyTNTq9zG2+lFNuZ+DXkURDTcwx5eTgltb9Fvh4F+Tz
         CMcUp64f+sI0RuqnEhEA8PSY/GOgGC9KvryUPBnUhnYstPcXhERsvkdYtN0rxCxr8bBN
         qnLVifpiVk3tGAO02BN/hbs5MrG6uQ3JpT1ffXvmNUfaQuLLZktj/m3cGf34d2S5ukGT
         Gfzyins/CCohDndO9hHSbnhJGz482djaBXoTV2kskKryk4EOtITRorEE9SnJxOQIQ2D2
         s5YQ==
X-Received: by 10.194.172.137 with SMTP id bc9mr33534114wjc.72.1410163696395;
        Mon, 08 Sep 2014 01:08:16 -0700 (PDT)
Received: from [192.168.4.120] (178-18-170-101.customer.bnet.at. [178.18.170.101])
        by mx.google.com with ESMTPSA id pk9sm10213836wjb.16.2014.09.08.01.08.15
        for <multiple recipients>
        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Mon, 08 Sep 2014 01:08:15 -0700 (PDT)
Sender: Michael Wallner <mike.php.net@gmail.com>
Message-ID: <540D63EE.7090600@php.net>
Date: Mon, 08 Sep 2014 10:08:14 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0
MIME-Version: 1.0
To: Sherif Ramadan <theanomaly.is@gmail.com>, 
 Tjerk Meesters <tjerk.meesters@gmail.com>
CC: Florian Margaine <florian@margaine.com>, 
 PHP Internals <internals@lists.php.net>
References: <CABRjmp_2DzhrGGoknZvSZ6fM=okjz+Od+2t0TVrNarc2fRLWiA@mail.gmail.com>	<CAHMUw2HVmJD9syo8Rbc1=bA5S3U9umS0_XHFzwzWsY9Ee7UneQ@mail.gmail.com> <CAL+t6cEfbd7KbB=EbhdqgLKG6tBURgj+Ls9Y62tjOHL1Y+r-SA@mail.gmail.com>
In-Reply-To: <CAL+t6cEfbd7KbB=EbhdqgLKG6tBURgj+Ls9Y62tjOHL1Y+r-SA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] setcookie() minor BC break - fixes issue #67736
From: mike@php.net (Michael Wallner)

On 08/09/14 09:15, Sherif Ramadan wrote:
> Actually, we shouldn't be doing that all. We should simply just overwrite
> the header. It wouldn't make much sense to set two headers with the same
> cookie name when we can just overwrite it.

Maybe, but the SAPI_HEADER_* only look for the header name, not its
contents.


-- 
Regards,
Mike