Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:77095
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAHMUw2HVmJD9syo8Rbc1=bA5S3U9umS0_XHFzwzWsY9Ee7UneQ@mail.gmail.com>
References: <CABRjmp_2DzhrGGoknZvSZ6fM=okjz+Od+2t0TVrNarc2fRLWiA@mail.gmail.com>
	<CAHMUw2HVmJD9syo8Rbc1=bA5S3U9umS0_XHFzwzWsY9Ee7UneQ@mail.gmail.com>
Date: Mon, 8 Sep 2014 03:15:05 -0400
Message-ID: <CAL+t6cEfbd7KbB=EbhdqgLKG6tBURgj+Ls9Y62tjOHL1Y+r-SA@mail.gmail.com>
To: Tjerk Meesters <tjerk.meesters@gmail.com>
Cc: Florian Margaine <florian@margaine.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=bcaec53d5e0306ff020502889441
Subject: Re: [PHP-DEV] setcookie() minor BC break - fixes issue #67736
From: theanomaly.is@gmail.com (Sherif Ramadan)

--bcaec53d5e0306ff020502889441
Content-Type: text/plain; charset=UTF-8

Actually, we shouldn't be doing that all. We should simply just overwrite
the header. It wouldn't make much sense to set two headers with the same
cookie name when we can just overwrite it.


On Mon, Sep 8, 2014 at 2:50 AM, Tjerk Meesters <tjerk.meesters@gmail.com>
wrote:

> Hi!
>
>
> On Sat, Sep 6, 2014 at 5:38 AM, Florian Margaine <florian@margaine.com>
> wrote:
>
> > Hi,
> >
> > This is a minor BC break, but still a BC break, so worth discussing on
> this
> > ML.
> >
> > When a second setcookie() is done with the same name, a warning is
> emitted,
> > because the ietf rfc 6265 says it *should* only send one Set-Cookie
> header
> > per name.
> >
> > This is fine when display_errors is set to off. When it's set to on, the
> > warning prevents the header from being added because "headers already
> sent"
> > (which is the minor BC break, as current PHP just sends 2 Set-Cookie
> > headers with the same name).
> >
>
> Yeah, it would prevent any header() or setcookie() following that warning
> from taking place.
>
> How about delaying that warning until the headers are sent?
>
>
> >
> > So, should it be merged? What should be done to comply with the ietf rfc
> > 6265?
> >
> > PR: https://github.com/php/php-src/pull/795/
> > PHP issue: https://bugs.php.net/bug.php?id=67736
> >
> > Regards,
> >
> > *Florian Margaine*
> >
>
>
>
> --
> --
> Tjerk
>

--bcaec53d5e0306ff020502889441--