Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:77093
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.51 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CABRjmp_2DzhrGGoknZvSZ6fM=okjz+Od+2t0TVrNarc2fRLWiA@mail.gmail.com>
References: <CABRjmp_2DzhrGGoknZvSZ6fM=okjz+Od+2t0TVrNarc2fRLWiA@mail.gmail.com>
Date: Mon, 8 Sep 2014 14:50:27 +0800
Message-ID: <CAHMUw2HVmJD9syo8Rbc1=bA5S3U9umS0_XHFzwzWsY9Ee7UneQ@mail.gmail.com>
To: Florian Margaine <florian@margaine.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c3536aef6b860502883b52
Subject: Re: [PHP-DEV] setcookie() minor BC break - fixes issue #67736
From: tjerk.meesters@gmail.com (Tjerk Meesters)

--001a11c3536aef6b860502883b52
Content-Type: text/plain; charset=UTF-8

Hi!


On Sat, Sep 6, 2014 at 5:38 AM, Florian Margaine <florian@margaine.com>
wrote:

> Hi,
>
> This is a minor BC break, but still a BC break, so worth discussing on this
> ML.
>
> When a second setcookie() is done with the same name, a warning is emitted,
> because the ietf rfc 6265 says it *should* only send one Set-Cookie header
> per name.
>
> This is fine when display_errors is set to off. When it's set to on, the
> warning prevents the header from being added because "headers already sent"
> (which is the minor BC break, as current PHP just sends 2 Set-Cookie
> headers with the same name).
>

Yeah, it would prevent any header() or setcookie() following that warning
from taking place.

How about delaying that warning until the headers are sent?


>
> So, should it be merged? What should be done to comply with the ietf rfc
> 6265?
>
> PR: https://github.com/php/php-src/pull/795/
> PHP issue: https://bugs.php.net/bug.php?id=67736
>
> Regards,
>
> *Florian Margaine*
>



-- 
--
Tjerk

--001a11c3536aef6b860502883b52--