Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:77081
Return-Path: <florian@margaine.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 28819 invoked from network); 5 Sep 2014 21:39:02 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 5 Sep 2014 21:39:02 -0000
Authentication-Results: pb1.pair.com header.from=florian@margaine.com; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=florian@margaine.com; spf=permerror; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain margaine.com from 209.85.213.179 cause and error)
X-PHP-List-Original-Sender: florian@margaine.com
X-Host-Fingerprint: 209.85.213.179 mail-ig0-f179.google.com  
Received: from [209.85.213.179] ([209.85.213.179:42465] helo=mail-ig0-f179.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id BC/08-12208-47D2A045 for <internals@lists.php.net>; Fri, 05 Sep 2014 17:39:01 -0400
Received: by mail-ig0-f179.google.com with SMTP id r2so85050igi.0
        for <internals@lists.php.net>; Fri, 05 Sep 2014 14:38:57 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:mime-version:from:date:message-id:subject:to
         :content-type;
        bh=F+pB4gZjO1ptpSrqJvw518fPi8NBdpvMifGN6NqrK5g=;
        b=BKlCE5BapfuX9w0uaoImDxv2pHEH9NdoRlPeCOhOMLLS0HlnsvyHJ2L5Hr2+QlcJCt
         9mMMDnWDwU3pdHHWyzi3FkUnzHRS8H3oiO1njN9kL72VKP7RwGiBQAxUclYEfc2BJTw1
         KbJD7wCiKEVyZEEaDZo3kFT57nR6NIKctQXWtfbI1rJgMHyzvbZeEC1COJGhq/xtihib
         LibCpVa5xht+ZzbZPCdgTuSqjFTiBdH3OZFMOAkVbecjBwd3o3VSd5Oh2meRqa3sbG9k
         DbMPzXSsnbEbyo2IfMH0uobtRkN/BiEtz6e2FpfD1efn94VOGT1VvHcUMQC8XBLUZzos
         zdGQ==
X-Gm-Message-State: ALoCoQmsdKvfNgObgZTLhqnLRqF3UiSawHO3eAMBDnqAEH2Mgu1IktdC5QAhHPvEbX/0Q1982S6Z
X-Received: by 10.50.66.133 with SMTP id f5mr8293254igt.38.1409953137874; Fri,
 05 Sep 2014 14:38:57 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.107.41.20 with HTTP; Fri, 5 Sep 2014 14:38:37 -0700 (PDT)
X-Originating-IP: [89.92.205.106]
Date: Fri, 5 Sep 2014 23:38:37 +0200
Message-ID: <CABRjmp_2DzhrGGoknZvSZ6fM=okjz+Od+2t0TVrNarc2fRLWiA@mail.gmail.com>
To: internals@lists.php.net
Content-Type: multipart/alternative; boundary=047d7bdc0faeeef1bb0502584b43
Subject: setcookie() minor BC break - fixes issue #67736
From: florian@margaine.com (Florian Margaine)

--047d7bdc0faeeef1bb0502584b43
Content-Type: text/plain; charset=UTF-8

Hi,

This is a minor BC break, but still a BC break, so worth discussing on this
ML.

When a second setcookie() is done with the same name, a warning is emitted,
because the ietf rfc 6265 says it *should* only send one Set-Cookie header
per name.

This is fine when display_errors is set to off. When it's set to on, the
warning prevents the header from being added because "headers already sent"
(which is the minor BC break, as current PHP just sends 2 Set-Cookie
headers with the same name).

So, should it be merged? What should be done to comply with the ietf rfc
6265?

PR: https://github.com/php/php-src/pull/795/
PHP issue: https://bugs.php.net/bug.php?id=67736

Regards,

*Florian Margaine*

--047d7bdc0faeeef1bb0502584b43--