Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:77059
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.50 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <5408545C.6040909@FamilleCollet.com>
References: <5408545C.6040909@FamilleCollet.com>
Date: Thu, 4 Sep 2014 19:02:08 +0200
Message-ID: <CAF+90c_hUKbup4eegiBeWi03XLTx47PRynCcHikgtXk5k-cayw@mail.gmail.com>
To: Remi Collet <Remi@famillecollet.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11347f46124d6505024050c5
Subject: Re: [PHP-DEV] STR_REALLOC definition in 5.6+
From: nikita.ppv@gmail.com (Nikita Popov)

--001a11347f46124d6505024050c5
Content-Type: text/plain; charset=UTF-8

On Thu, Sep 4, 2014 at 2:00 PM, Remi Collet <Remi@famillecollet.com> wrote:

> For now:
>
> #define STR_REALLOC(ptr, size) \
>                         ptr = (char *) erealloc(ptr, size);
>
>
> Dealing with https://github.com/phalcon/cphalcon/pull/2772
>
> I switch from realloc to str_realloc.
> But this is not portable (str_realloc is 5.6+ only)
>
> STR_REALLOC should be better, as portable, 5.0+
>
> But should be defined as str_erealloc
>
> What do you think ?
>
>
> Probably too late, as if we fix this definition, it will portable in all
> versions > 5.0 except 5.6.0 :(
>

Given that interned strings have been added in PHP 5.4 and STR_REALLOC has
been defined like that for all the existing 5.4 and 5.5 releases, you'd
have to do a version check in any case. So I don't see much point in this...

Nikita

--001a11347f46124d6505024050c5--