Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:77038
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain beccati.com designates 176.9.114.167 as permitted sender)
Message-ID: <5405CDA0.8010401@beccati.com>
Date: Tue, 02 Sep 2014 16:01:04 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.0
MIME-Version: 1.0
To: "guilhermeblanco@gmail.com" <guilhermeblanco@gmail.com>
CC: PHP internals <internals@lists.php.net>
References: <5405BD15.2070602@beccati.com> <CAFp73XtV475nndwuwbtCu+6wO+CO7KkxfcxbUXz7Ya5it6odBQ@mail.gmail.com>
In-Reply-To: <CAFp73XtV475nndwuwbtCu+6wO+CO7KkxfcxbUXz7Ya5it6odBQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Optional nowait argument to sem_acquire
From: php@beccati.com (Matteo Beccati)

Hi,

On 02/09/2014 15:38, guilhermeblanco@gmail.com wrote:
> I'd propose instead of accepting "nowait" only, I'd use a better support
> and accept "until", dealing with possible cases:
> 
>   * -1: Blocks and wait until lock is acquired
>   * 0: Exactly what your patch does, attempt to grab and if it fails,
>     just return false (I'd remove the E_WARNING)

(It doesn't. The warning is raised when the semaphore can't be acquired
for other reasons)

>   * > 0: Acceptable time in milliseconds it would wait until consider
>     the acquire failed

TBH, I don't know. semtimedop is not universally available (no BSD, as
far as I can tell) and I would prefer to avoid writing an alternative
implementation in case it's not available. On the other hand triggering
an error in such case wouldn't be nice.


Cheers
-- 
Matteo Beccati

Development & Consulting - http://www.beccati.com/