Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:77037 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 90539 invoked from network); 2 Sep 2014 13:39:04 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 Sep 2014 13:39:04 -0000 Authentication-Results: pb1.pair.com smtp.mail=guilhermeblanco@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=guilhermeblanco@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.181 as permitted sender) X-PHP-List-Original-Sender: guilhermeblanco@gmail.com X-Host-Fingerprint: 209.85.223.181 mail-ie0-f181.google.com Received: from [209.85.223.181] ([209.85.223.181:46684] helo=mail-ie0-f181.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 31/11-18348-478C5045 for ; Tue, 02 Sep 2014 09:39:01 -0400 Received: by mail-ie0-f181.google.com with SMTP id rp18so7609954iec.40 for ; Tue, 02 Sep 2014 06:38:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=Sou181bv3mLJJuoHeqTEntYLL5dT1QlKz3uktJaaHoM=; b=vJ+7XefeX1pTvIcWpLIMox03me/qX0TKtXfM9O6CRobPKIIF6cZ4SNdrSBPtt437qX aoxh7AjOZLFGMypdySZ/9AYSx/cZjXGL8HZrAfufPQezmCtDyZH73By+KiskvhBIvlIl bg7HABMDk4Os+jg8Pe2Xhdc1xcmSULi+c4vU2l36g5XsXd8v77B0SpEPx6Ca8Uqss3y1 VNfFNrwgCLU4VHm4nr69UrwwDEaVIKCxs3BlZ5EMCsI8NwtwTyS6ct+1L+k4GZplyRZh OlLS80JvNn9vNnKoKtiQ42qUu9PBoAhd4JImhB3enScFJtqte0dVk49Lcxs0w6IMilmV 1Gcw== X-Received: by 10.42.212.146 with SMTP id gs18mr753622icb.96.1409665137319; Tue, 02 Sep 2014 06:38:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.8.24 with HTTP; Tue, 2 Sep 2014 06:38:37 -0700 (PDT) In-Reply-To: <5405BD15.2070602@beccati.com> References: <5405BD15.2070602@beccati.com> Date: Tue, 2 Sep 2014 09:38:37 -0400 Message-ID: To: Matteo Beccati Cc: PHP internals Content-Type: multipart/alternative; boundary=485b397dd05fc323820502153d73 Subject: Re: [PHP-DEV] Optional nowait argument to sem_acquire From: guilhermeblanco@gmail.com ("guilhermeblanco@gmail.com") --485b397dd05fc323820502153d73 Content-Type: text/plain; charset=UTF-8 Hi, Since I don't know where you guys like to discuss implementations, I'm pasting same thing I did in php-src PR: I'd propose instead of accepting "nowait" only, I'd use a better support and accept "until", dealing with possible cases: - -1: Blocks and wait until lock is acquired - 0: Exactly what your patch does, attempt to grab and if it fails, just return false (I'd remove the E_WARNING) - > 0: Acceptable time in milliseconds it would wait until consider the acquire failed Cheers, On Tue, Sep 2, 2014 at 8:50 AM, Matteo Beccati wrote: > Hi everyone, > > the following patch: > > https://github.com/php/php-src/pull/741 > > has been lying around somewhere on my box since years and I recently > stumbled upon it. > > However 5.6 was already RC and Ferenc suggested to eventually wait for > 5.6.1. > > Do you think it's ok to add such a minor feature to 5.6.1? > > > Cheers > -- > Matteo Beccati > > Development & Consulting - http://www.beccati.com/ > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > -- Guilherme Blanco MSN: guilhermeblanco@hotmail.com GTalk: guilhermeblanco Toronto - ON/Canada --485b397dd05fc323820502153d73--