Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:77036
Return-Path: <jocelyn.fournier@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 88002 invoked from network); 2 Sep 2014 13:15:46 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 2 Sep 2014 13:15:46 -0000
Authentication-Results: pb1.pair.com header.from=jocelyn.fournier@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=jocelyn.fournier@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.179 as permitted sender)
X-PHP-List-Original-Sender: jocelyn.fournier@gmail.com
X-Host-Fingerprint: 74.125.82.179 mail-we0-f179.google.com  
Received: from [74.125.82.179] ([74.125.82.179:33899] helo=mail-we0-f179.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id EA/90-18348-003C5045 for <internals@lists.php.net>; Tue, 02 Sep 2014 09:15:46 -0400
Received: by mail-we0-f179.google.com with SMTP id t60so6854676wes.24
        for <internals@lists.php.net>; Tue, 02 Sep 2014 06:15:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=from:message-id:date:user-agent:mime-version:to:cc:subject
         :references:in-reply-to:content-type:content-transfer-encoding;
        bh=8v6YwfXklKpemn2f7N+ItG7qK9bI6Jom+LJOHBDIk8c=;
        b=CGEFr4NkAZZCys3fctq7xW/ChEN81CLAyvsUC/ZqCyesMfg9Yxt+yyyDCt337zyAnR
         5x/UQfRJADdLjOi3Hns70PQ/yNscl5QQMvFCDSWqs0oTr9VjPVAgV2RD0fywVhXt7Wbv
         8UXBCzLqpHXpKqyiVtqgonVPsflWxYgzYFra9aLZU2p67nxglkYXe6izhgpTHHMivr9P
         UnE3RSSrwDxm4Hxxp7/Bp6DMlUNAHqMb9luVrAE6Rrbym8cv+EYq+OjZjISU+x+dreR4
         lJJvpH0GF1O/CQKCvoDH3BSmFXW5EKunLvB+0OdIyosC6H42ofqhr0XmbYwfSPlXnARF
         21OQ==
X-Received: by 10.195.12.103 with SMTP id ep7mr2840835wjd.121.1409663741513;
        Tue, 02 Sep 2014 06:15:41 -0700 (PDT)
Received: from MacBook-Pro-de-jocelyn-fournier.local ([2a01:e35:2ea9:c3d0:dd95:d9d9:3b5:344d])
        by mx.google.com with ESMTPSA id h6sm9431602wjb.33.2014.09.02.06.15.40
        for <multiple recipients>
        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Tue, 02 Sep 2014 06:15:40 -0700 (PDT)
X-Google-Original-From: jocelyn fournier <jocelyn.fournier@gmail.Com>
Message-ID: <5405C2FB.9030301@gmail.Com>
Date: Tue, 02 Sep 2014 15:15:39 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.0
MIME-Version: 1.0
To: Stas Malyshev <smalyshev@sugarcrm.com>, 
 Nikita Popov <nikita.ppv@gmail.com>
CC: PHP Internals <internals@lists.php.net>, 
 Dmitry Stogov <dmitry@zend.com>
References: <54027B6D.7060708@sugarcrm.com> <CAF+90c_UuEmLiVE=501kz60X=E=L8V=Dwwka9jwfdPYaVDNbjQ@mail.gmail.com> <54036DEA.8060902@sugarcrm.com> <5405783D.5010204@sugarcrm.com>
In-Reply-To: <5405783D.5010204@sugarcrm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] destructors and output_buffering
From: jocelyn.fournier@gmail.com (jocelyn fournier)

Hi,

One line fix, nice :)

A quick question about how resources are freed :
if some variables are computed inside a singleton and read through a 
myclass::instance()->get_my_variable(), should we expect to have those 
variables available when calling ob_start() callbacks ?

 From experiment, they are still available, but since 
zend_call_destructors is called before ob_start(), I wonder if this is a 
safe behaviour.

Thanks,
   Jocelyn



Le 02/09/2014 09:56, Stas Malyshev a écrit :
> Hi!
>
> I've created a proposed fix for #67644:
>
> https://github.com/php/php-src/pull/798
>
> It is the most conservative one which I'm thinking of putting into 5.4,
> so that at least we won't have segfaults. If we want to improve upon it,
> we can do that in 5.5/5.6, but I'd like at least plug the segfaults in
> 5.4 for now.
>
> Any objections to this or better proposals?
>