Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:77018 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 20342 invoked from network); 1 Sep 2014 20:49:23 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 1 Sep 2014 20:49:23 -0000 Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 108.166.43.67 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 108.166.43.67 smtp67.ord1c.emailsrvr.com Linux 2.6 Received: from [108.166.43.67] ([108.166.43.67:58516] helo=smtp67.ord1c.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id E7/C2-03336-2DBD4045 for ; Mon, 01 Sep 2014 16:49:22 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp1.relay.ord1c.emailsrvr.com (SMTP Server) with ESMTP id D9F22380451; Mon, 1 Sep 2014 16:49:19 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp1.relay.ord1c.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id 5D49D380416; Mon, 1 Sep 2014 16:49:19 -0400 (EDT) X-Sender-Id: smalyshev@sugarcrm.com Received: from Stass-MacBook-Pro.local (108-66-6-48.lightspeed.sntcca.sbcglobal.net [108.66.6.48]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA) by 0.0.0.0:465 (trex/5.2.10); Mon, 01 Sep 2014 20:49:19 GMT Message-ID: <5404DBD1.8050604@sugarcrm.com> Date: Mon, 01 Sep 2014 13:49:21 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Matt Wilmas , "internals@lists.php.net" CC: Pierre Joye , Anatol Belski References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [INTERNALS-WIN] [PATCH] Microsecond resolution and accuracy on Windows From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > It's much more optimized than what's there now, and slightly over the old > implementation. Not sure if I should give the saved patch link, or the > "live compare" (?) on Github, so I'll do both for now: > http://realplain.com/php/microtime_5_4.diff > https://github.com/matt-moo/php-src/compare/PHP-5.4.diff > > Against 5.4 since that's what I quickly worked on so it's ready for the next > 5.4 release (Stas?). (Although I guess we're supposed to change the oldest > branch usually?) Looking at the patch, it looks like unfortunately it changes a global structure (_php_win32_core_globals) which breaks binary compatibility. I think if you move the additional value to the end of the structure it should be ok though, since other offsets should not change then. I'm also not sure how important it is how have it for 5.4. Does the problem that this patch fixes exist only in older versions of Windows or on all versions? What are the actual effects of this problem - is it just lower resolution of microtime or there can be something seriously wrong with the whole result? If it's just lower resolution, I'd prefer this to go into 5.5 as the change is pretty extensive. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/