Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:77002
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.217.169 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <E4EDB8A3-20DD-4DB9-AEB8-581B42222628@ajf.me>
References: <E4EDB8A3-20DD-4DB9-AEB8-581B42222628@ajf.me>
Date: Mon, 1 Sep 2014 11:56:04 +0800
Message-ID: <CABBJUpedHeCArT+8YqUv906vQSbWJ_hvcjgbg-J5CNYZQhyHUg@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Make zend_parse_parameters emit E_RECOVERABLE_ERROR
From: laruence@php.net (Xinchen Hui)

On Mon, Sep 1, 2014 at 6:01 AM, Andrea Faulds <ajf@ajf.me> wrote:
> Good evening,
>
> Here=E2=80=99s a suggestion: Why don=E2=80=99t we make zend_parse_paramet=
ers emit

""Why not" is usually not a very good reason for a change in the language
syntax. " -- Stas

> E_RECOVERABLE_ERROR on failure, rather than just emitting E_WARNING and
> returning FAILURE (causing the caller to typically bail out and return NU=
LL)?
> This would bring it into line with userland type hints, which also cause =
such
> errors. It might also cause errors to be caught sooner, as just returning=
 NULL
> can cause cryptic problems down the line. It=E2=80=99s worth noting that
> zend_parse_parameters is very tolerant in terms of what parameters you ca=
n pass
> it and is unlikely to error unless you do something really weird such as
> passing an array to strlen().
PHP is a looser type language... such things might be happened. and
internal functions always check their arguments.

this will make the PHP app more robust.
> I doubt this would affect backwards compatibility
> much, unless your application relies on a silenced warning (which is poss=
ible,
> but discouraged behaviour), and it=E2=80=99s the type of BC break that wo=
uld be really
> obvious (your application errors and stops execution).
that will be a nightmare to stop people upgrade their PHP.

thanks
>
> Thoughts?
> --
> Andrea Faulds
> http://ajf.me/
>
>
>
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>



--=20
Xinchen Hui
@Laruence
http://www.laruence.com/