Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:76987
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.177 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <fd7539872e45363348ae3c12890080eb.squirrel@webmail.klapt.com>
References: <2afc5a878ff4c780c74f4604f77525c1.squirrel@webmail.klapt.com>
	<CABBJUpfeD3T1s5BpUvL-svtKXYxmHRbutzdagm+p8SOjuNnr_Q@mail.gmail.com>
	<fd7539872e45363348ae3c12890080eb.squirrel@webmail.klapt.com>
Date: Sun, 31 Aug 2014 14:12:47 +0200
Message-ID: <CAEZPtU5x=b=OoWQZh_SSTj_PaF1ePRpra8FnFfEUWQaiMsbGyw@mail.gmail.com>
To: Anatol Belski <anatol.php@belski.net>
Cc: Dmitry Stogov <dmitry@zend.com>, PHP internals <internals@lists.php.net>, 
	Nikita Popov <nikita.ppv@gmail.com>, Xinchen Hui <laruence@php.net>
Content-Type: multipart/alternative; boundary=001a11c23276f1f7030501ebcdce
Subject: Re: [PHP-DEV] Re: 64 bit string offsets
From: pierre.php@gmail.com (Pierre Joye)

--001a11c23276f1f7030501ebcdce
Content-Type: text/plain; charset=UTF-8

Hi Anatol,

Thanks!

For what I see it should have no impact, either mem usage or perf but when
such offset is used, in 64bit.

However some numbers are better, could you provide some using exclusively
this syntax and using common apps pls? Only to be sure.

Cheers,
Pierre
On Aug 31, 2014 1:57 PM, "Anatol Belski" <anatol.php@belski.net> wrote:

> On Fri, August 29, 2014 18:34, Xinchen Hui wrote:
> > On Fri, Aug 29, 2014 at 11:49 PM, Anatol Belski <anatol.php@belski.net>
> > wrote:
> >
> >> Hi,
> >>
> >>
> >> while refining the big string support, it turned out that we've an
> >> issue. The syntax like $s[42] = 'x'; is currently inconsistend, because
> >> we have uint32 for string offsets. This actually means, the behaviour is
> >> currently only available in the old style and can handle not more than
> >> 2gb big
> >> strings.
> >>
> >> Also discussed with Laruence on IRC and he actually expressed the
> >> concern that we pay overhead on that. From my side I was investigating
> >> on that and could suggest several solutions for that:
> >>
> >> - stay with the old behavior (indexes would be able to handle only 2gb
> >> strings, this is the status quo)
> >
> > I think it's okey. maybe throw a warning if it's bigger than 32bits?
> >
> >
>
> Here's a patch http://belski.net/phpz/64_str_offset.patch fixing the the
> 64 bit offsets. Please take a look, maybe we'd have a perspective with it.
> So far the test suite tells no difference.
>
> Thanks
>
> Anatol
>

--001a11c23276f1f7030501ebcdce--