Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:76985 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 96305 invoked from network); 31 Aug 2014 11:57:58 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 31 Aug 2014 11:57:58 -0000 Authentication-Results: pb1.pair.com header.from=anatol.php@belski.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=anatol.php@belski.net; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error) X-PHP-List-Original-Sender: anatol.php@belski.net X-Host-Fingerprint: 85.214.73.107 klapt.com Received: from [85.214.73.107] ([85.214.73.107:60948] helo=h1123647.serverkompetenz.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id EB/00-30065-1CD03045 for ; Sun, 31 Aug 2014 07:57:54 -0400 Received: by h1123647.serverkompetenz.net (Postfix, from userid 33) id 56E036D209C; Sun, 31 Aug 2014 13:57:50 +0200 (CEST) Received: from 93.205.113.119 (SquirrelMail authenticated user anatol@belski.net) by webmail.klapt.com with HTTP; Sun, 31 Aug 2014 13:57:50 +0200 Message-ID: In-Reply-To: References: <2afc5a878ff4c780c74f4604f77525c1.squirrel@webmail.klapt.com> Date: Sun, 31 Aug 2014 13:57:50 +0200 To: "Xinchen Hui" Cc: "Anatol Belski" , "PHP Internals" , "Nikita Popov" , "Pierre Joye" , "Dmitry Stogov" User-Agent: SquirrelMail/1.5.2 [SVN] MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [PHP-DEV] Re: 64 bit string offsets From: anatol.php@belski.net ("Anatol Belski") On Fri, August 29, 2014 18:34, Xinchen Hui wrote: > On Fri, Aug 29, 2014 at 11:49 PM, Anatol Belski > wrote: > >> Hi, >> >> >> while refining the big string support, it turned out that we've an >> issue. The syntax like $s[42] = 'x'; is currently inconsistend, because >> we have uint32 for string offsets. This actually means, the behaviour is >> currently only available in the old style and can handle not more than >> 2gb big >> strings. >> >> Also discussed with Laruence on IRC and he actually expressed the >> concern that we pay overhead on that. From my side I was investigating >> on that and could suggest several solutions for that: >> >> - stay with the old behavior (indexes would be able to handle only 2gb >> strings, this is the status quo) > > I think it's okey. maybe throw a warning if it's bigger than 32bits? > > Here's a patch http://belski.net/phpz/64_str_offset.patch fixing the the 64 bit offsets. Please take a look, maybe we'd have a perspective with it. So far the test suite tells no difference. Thanks Anatol