Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:7697
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
To: Andrey Hristov <php@hristov.com>
Message-ID: <1076416395.4028cf8bf2fa3@webmail.eclipse.net.uk>
Date: Tue, 10 Feb 2004 12:33:15 +0000 (GMT)
Cc: internals@lists.php.net
References: <20040210005241.A2CDB2E3116@mra03.ex.eclipse.net.uk> <1076401823.4028969f975f2@hristov.com>
In-Reply-To: <1076401823.4028969f975f2@hristov.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Eclipse Internet Webmail 2.2.6
Subject: Re: [PHP-DEV] FW: [PATCH] Bug #24064: Standard deviation
From: webjedi@hudzilla.eclipse.co.uk (Paul Hudson)

Andrey, 
 
I compiled with "--enable-debug" already (but did it 
again just to make sure).  It works fine, with no report of 
leaks.  Did I miss something? 
 
Jani: You're absolutely right about the comments; sorry 
about that! 
 
Otherwise, is the patch OK to be committed? 
 
 
Paul 
-- 
 
Quoting Andrey Hristov <php@hristov.com>: 
 
> Hi Paul,  
> may you compile your PHP binary with 
> --enable-debug and after that run your  
> sample scrit for once. See if there are leaks. 
>  
>   
> Andrey  
>   
> Quoting Paul Hudson 
> <webjedi@hudzilla.eclipse.co.uk>:  
>   
> > Er, either the php-internals MARC archive 
> doesn't show all attachments, or  
> > my diff file got stripped en route for not 
> having a .txt extension.  I've  
> > attached it again, just to make sure.  
> >   
> >   
> > Paul  
> > --  
> >   
> > -----Original Message-----  
> > From: Paul Hudson 
> [mailto:webjedi@hudzilla.eclipse.co.uk]   
> > Sent: 10 February 2004 00:30  
> > To: 'internals@lists.php.net'  
> > Subject: [PATCH] Bug #24064: Standard 
> deviation  
> >   
> > Hi there,  
> >   
> > Bug #24064 (submitted by tularis@php.net) 
> requests a standard deviation  
> > function for PHP.  I realise that any of you 
> could implement this in 10  
> > minutes, but according to the bug database it 
> is still Open so I figured I  
> > would give it a try myself!  
> >   
> > There are probably a dozen errors in the code 
> and/or places where it could  
> > be better optimised, but I'm hoping one of you 
> might be able to help with  
> > that.  So, the attached diff file implements 
> the function array_std_dev(),  
> > to calculate standard deviation using the 
> deviation method.  
> >   
> > With the function in place, standard deviation 
> is calculated like this:  
> >   
> > <?php  
> >   $scores = array(18,5,7,18,3,2,10);  
> >   print array_std_dev($score);  
> >   // prints 6.6833125519211  
> > ?>  
> >   
> > My first attempt at implementing this was 
> using an extra array to buffer the  
> > deviations - this was more out of curiosity to 
> see how the array stuff  
> > works.  Sadly, it caused PHP to segfault and I 
> couldn't figure out why - can  
> > any of you help me spot the brain fart?  (I've 
> attached the offending code  
> > in bad_stddev_code.txt)  
> >   
> > Yours,  
> >   
> >   
> > Paul  
> >   
> > PS: I'm not on the internals list, so I would 
> appreciate it if you would CC  
> > me on your reply.  
> >   
>   
>   
>