Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:76964
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.44 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CFFB1EB0-9A47-4F72-9E9D-28E2D2D5C447@gmail.com>
References: <CFFB1EB0-9A47-4F72-9E9D-28E2D2D5C447@gmail.com>
Date: Sat, 30 Aug 2014 12:41:02 +0200
Message-ID: <CAF+90c9yn-npOuyx5S2HW=xSSP9uZDbaJKhYKeOisKsNHYt5fQ@mail.gmail.com>
To: Tjerk Meesters <tjerk.meesters@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e0160b432fd697b0501d66710
Subject: Re: [PHP-DEV] [RFC] Loosening heredoc/nowdoc scanner
From: nikita.ppv@gmail.com (Nikita Popov)

--089e0160b432fd697b0501d66710
Content-Type: text/plain; charset=UTF-8

On Sat, Aug 30, 2014 at 2:33 AM, Tjerk Meesters <tjerk.meesters@gmail.com>
wrote:

> Hi internals,
>
> I would like to propose a few changes to our heredoc / nowdoc scanner to
> make it less awkward to use inside other constructs.
>
> https://wiki.php.net/rfc/heredoc-scanner-loosening
>
> Let me know your thoughts :)
>

+1 on removing heredoc/nowdoc restrictions. Having to add a newline after
the terminator is very clumsy. We acknowledge this fact by special casing
the semicolon, but don't follow through by just removing the requirement.

If we allow people to choose their own terminator, they can damn well
choose one that causes no conflicts. I mean, what else is the point of this
feature?

On a technical note, if you go for not removing the restriction entirely,
then all characters that are not valid heredoc labels should be allowed
afterwards. E.g. your current list misses ) for use in a function call and
likely any other number of characters.

Nikita

--089e0160b432fd697b0501d66710--