Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:76906 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 21569 invoked from network); 27 Aug 2014 11:53:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Aug 2014 11:53:50 -0000 Authentication-Results: pb1.pair.com header.from=ajf@ajf.me; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=ajf@ajf.me; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ajf.me designates 192.64.116.200 as permitted sender) X-PHP-List-Original-Sender: ajf@ajf.me X-Host-Fingerprint: 192.64.116.200 imap1-2.ox.privateemail.com Received: from [192.64.116.200] ([192.64.116.200:49942] helo=imap1-2.ox.privateemail.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 9A/50-19261-DC6CDF35 for ; Wed, 27 Aug 2014 07:53:49 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.privateemail.com (Postfix) with ESMTP id 65958B00094; Wed, 27 Aug 2014 07:53:45 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at imap1.ox.privateemail.com Received: from mail.privateemail.com ([127.0.0.1]) by localhost (imap1.ox.privateemail.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Twj07cKEt4Bi; Wed, 27 Aug 2014 07:53:45 -0400 (EDT) Received: from [192.168.0.2] (05439dda.skybroadband.com [5.67.157.218]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.privateemail.com (Postfix) with ESMTPSA id 00158B00091; Wed, 27 Aug 2014 07:53:43 -0400 (EDT) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) In-Reply-To: <62188C5D-C62B-493F-8CB1-9B48C5555131@gmail.com> Date: Wed, 27 Aug 2014 12:53:41 +0100 Cc: PHP Internals Content-Transfer-Encoding: quoted-printable Message-ID: <63BF27F9-C684-418A-883D-A8D7695FF42F@ajf.me> References: <62188C5D-C62B-493F-8CB1-9B48C5555131@gmail.com> To: Tjerk Meesters X-Mailer: Apple Mail (2.1878.6) Subject: Re: [PHP-DEV] Re: zpp and zend_string From: ajf@ajf.me (Andrea Faulds) On 27 Aug 2014, at 06:34, Tjerk Meesters = wrote: > With the recent merge of int64 the `zend_string` type now uses = `size_t` to store its length, but ZPP (and friends) still use `int *` to = store the parsed string lengths. >=20 > http://lxr.php.net/xref/PHP_TRUNK/Zend/zend_API.c#519 >=20 > This look like an oversight. Will this be fixed as well? While we=92re at it, why does zpp take an int* for param_count when you = use *? The type of param_count in zend_fcall_info is uint32_t (formerly = zend_uint), and if you=92re using *, that=92s the struct member you=92ll = be giving zpp a pointer to. -- Andrea Faulds http://ajf.me/