Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:76901
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.182 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAH-PCH4amO2RMvNu=fxoj2eOeOjABoae724bTYc3P_JWg+rFWA@mail.gmail.com>
References: <CAF+90c_M7nKiVLYT0vWaq8wg==Yz0ZZC1V_ke=t71rpWqKPepA@mail.gmail.com>
	<CAF+90c-d6=rSN5Z-cngmEO-bheFF_0JR7iJ4uhFZWVMfRdL2Ug@mail.gmail.com>
	<53FB6D4C.9070705@php.net>
	<CAF+90c8+3Otfw3Mscm8FcNTObHr+_id6bDkLw7DW5xmATgRfkg@mail.gmail.com>
	<53FBAD09.1080108@sugarcrm.com>
	<CAHXmDMB5WZWuQugA1UO-xPX9JFWn228+kSk+jwwUuEOKQUbfpA@mail.gmail.com>
	<53FBC2E1.2000404@sugarcrm.com>
	<CAEPJdu=F2VrKT1VWyJOB=wmQqbuGDm_DV41YH0adBP0DFdMuzA@mail.gmail.com>
	<C054D56D-910F-4747-9B4C-CE3869BFCD4F@ajf.me>
	<CAH-PCH4amO2RMvNu=fxoj2eOeOjABoae724bTYc3P_JWg+rFWA@mail.gmail.com>
Date: Wed, 27 Aug 2014 00:38:00 -0700
Message-ID: <CAMbn9ZEZ7sgaa283uEjsagjzYPXSz-Ks5gX+WPFMpz2HPizKAg@mail.gmail.com>
To: Ferenc Kovacs <tyra3l@gmail.com>
Cc: Andrea Faulds <ajf@ajf.me>, Benjamin Eberlei <kontakt@beberlei.de>, 
	Stas Malyshev <smalyshev@sugarcrm.com>, Trevor Suarez <rican7@gmail.com>, 
	Nikita Popov <nikita.ppv@gmail.com>, Sebastian Bergmann <sebastian@php.net>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e013d15d4e023320501977f25
Subject: Re: [PHP-DEV] Re: [VOTE] Abstract Syntax Tree
From: themattficken@gmail.com (Matt Ficken)

--089e013d15d4e023320501977f25
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

I get no new test failures on master after AST merged.

Before and after the AST merge, I still get ~200 tests failing on Windows.

My test runs turned up a few crashes, which I am reproducing to get BTs to
share. I'm not sure if the crashes are AST related.




On Tue, Aug 26, 2014 at 2:50 AM, Ferenc Kovacs <tyra3l@gmail.com> wrote:

> On Tue, Aug 26, 2014 at 1:58 AM, Andrea Faulds <ajf@ajf.me> wrote:
>
> >
> > On 26 Aug 2014, at 00:53, Benjamin Eberlei <kontakt@beberlei.de> wrote:
> >
> > > Depends, registering for shutdown handlers and catching fatals is a
> > pretty
> > > common thing. If EngineException does not get caught, it should produ=
ce
> > an
> > > E_FATAL again with the correct error code.
> >
> > Exceptions already do this, do they not? I don=E2=80=99t see why those =
exceptions
> > would be any different.
> >
>
> people have code out there like this:
> try {
>   //something stupid
> } catch (Exception $e) {
>   //do nothing or maybe log it
> }
>
> if we turn fatal errors into Exceptions extending the base Exception clas=
s,
> these Pok=C3=A9mon constructs ("Gotta Catch 'Em All") will will swallow t=
hose
> errors and contrinue the execution, maybe causing more dangerous
> results(data corruption, etc.) than a simple fatal error could.
> But these issues was discussed before, so I'm fairly sure that Nikita is
> aware of those concerns, and let's just wait for him to update his propos=
al
> and we can discuss it after it's ready.
>
> --
> Ferenc Kov=C3=A1cs
> @Tyr43l - http://tyrael.hu
>

--089e013d15d4e023320501977f25--