Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:76899
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
Message-ID: <221c660eb11d0f30bb065bbc34e657f4.squirrel@webmail.klapt.com>
In-Reply-To: <62188C5D-C62B-493F-8CB1-9B48C5555131@gmail.com>
References: <62188C5D-C62B-493F-8CB1-9B48C5555131@gmail.com>
Date: Wed, 27 Aug 2014 08:51:11 +0200
To: "Tjerk Meesters" <tjerk.meesters@gmail.com>
Cc: "PHP Internals" <internals@lists.php.net>
User-Agent: SquirrelMail/1.5.2 [SVN]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] Re: zpp and zend_string
From: anatol.php@belski.net ("Anatol Belski")

Hi Tjerk,

On Wed, August 27, 2014 07:34, Tjerk Meesters wrote:
> Hi internals,
>
>
> With the recent merge of int64 the `zend_string` type now uses `size_t`
> to store its length, but ZPP (and friends) still use `int *` to store the
> parsed string lengths.
>
> http://lxr.php.net/xref/PHP_TRUNK/Zend/zend_API.c#519
>
>
Yep, this is a good question, as that zend_string uses size_t for the
length now with 'S', but 's' goes the old way. IMHO we should let it be as
it is, or even enforce 's' length to be exact unsigned 32 bit. And, we
should check for places where we need the conversion to zend_string -
those are

- where we work with pure strings in PHP, like substr() for example
- where the dependency library requieres or supports that

As example - it makes no sense to use zend_string for zlib or ICU, but
it's fulle justified for iconv.

Regards

Anatol