Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:76894 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 54441 invoked from network); 26 Aug 2014 23:22:06 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 26 Aug 2014 23:22:06 -0000 Authentication-Results: pb1.pair.com header.from=ajf@ajf.me; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=ajf@ajf.me; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ajf.me designates 192.64.116.207 as permitted sender) X-PHP-List-Original-Sender: ajf@ajf.me X-Host-Fingerprint: 192.64.116.207 imap2-2.ox.privateemail.com Received: from [192.64.116.207] ([192.64.116.207:52709] helo=imap2-2.ox.privateemail.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id AB/41-46492-D961DF35 for ; Tue, 26 Aug 2014 19:22:05 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.privateemail.com (Postfix) with ESMTP id 83AA68C007D; Tue, 26 Aug 2014 19:22:02 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at imap2.ox.privateemail.com Received: from mail.privateemail.com ([127.0.0.1]) by localhost (imap2.ox.privateemail.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id gAALaWBGhky3; Tue, 26 Aug 2014 19:22:02 -0400 (EDT) Received: from [192.168.0.2] (05439dda.skybroadband.com [5.67.157.218]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.privateemail.com (Postfix) with ESMTPSA id 17D738C0075; Tue, 26 Aug 2014 19:22:00 -0400 (EDT) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) In-Reply-To: <53FCF94F.1090702@sugarcrm.com> Date: Wed, 27 Aug 2014 00:21:58 +0100 Cc: Nikita Popov , PHP internals Content-Transfer-Encoding: quoted-printable Message-ID: References: <23EA2BFD-AAA8-4D5E-92D6-8D7B57332291@ajf.me> <53FCF94F.1090702@sugarcrm.com> To: Stas Malyshev X-Mailer: Apple Mail (2.1878.6) Subject: Re: [PHP-DEV] Remove generated VM from git? From: ajf@ajf.me (Andrea Faulds) On 26 Aug 2014, at 22:17, Stas Malyshev wrote: > That's not an advantage. Having extra file in git is no problem at = all, > we don't pay per byte, and somebody who can't handle regenerating the = VM > file should not be messing with the VM (for one, they would notice the > problem immediately on running the test for the change locally, and if > they don't test the changes locally we probably don't want these > changes). And it's not like we change the VM every day. Actually, I wouldn=92t be so bothered by this if I didn=92t have to = manually regenerate the VM. Would it be possible to make `make` track = Zend/zend_vm_def.h? -- Andrea Faulds http://ajf.me/