Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:76890
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain ajf.me designates 192.64.116.207 as permitted sender)
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
In-Reply-To: <CAF+90c-30vUGk+7TWSxrPE4JZwf+ex9_z6VnOx-Rq9eC+RhPNg@mail.gmail.com>
Date: Tue, 26 Aug 2014 21:30:16 +0100
Cc: PHP internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <23EA2BFD-AAA8-4D5E-92D6-8D7B57332291@ajf.me>
References: <CAF+90c9b6aRNNvJ6QVmumGgBW8=+dPxiByYY0h8M6x+L+BrYWQ@mail.gmail.com> <CDCB5583-7313-47B3-8E16-9694FCF7E0ED@ajf.me> <CAF+90c-30vUGk+7TWSxrPE4JZwf+ex9_z6VnOx-Rq9eC+RhPNg@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>,
 Stas Malyshev <smalyshev@sugarcrm.com>
Subject: [PHP-DEV] Remove generated VM from git?
From: ajf@ajf.me (Andrea Faulds)

Hi!

Spinning this discussion (removing generated VM from git) off into its =
own thread.

On 26 Aug 2014, at 21:12, Nikita Popov <nikita.ppv@gmail.com> wrote:

> -1 on removing zend_vm_execute.h. Having to install php before I can =
build php would be very inconvenient.

I=92d point out PHP already requires extra dependencies (and your =
proposal adds one further) before building PHP from git. I also doubt it =
would cause inconvenience to developers, as if you=92re developing PHP =
you need a stable PHP install anyway. You wouldn=92t need PHP to build =
PHP for most cases, only if you=92re building it from git.


On 26 Aug 2014, at 21:08, Stas Malyshev <smalyshev@sugarcrm.com> wrote:

> That would make building PHP for non-internals person harder and the
> list of dependencies they need to get right longer. While providing =
zero
> added value. And yes, there are a lot of non-internals persons =
building
> PHP. Sometimes they may even use git.

Why would a non-internals person want to build PHP from git? That=92s =
just making things harder on themselves. Besides PHP itself (should my =
proposal succeed), you need other extra dependencies, including a lexer =
generator if Nikita=92s proposal succeeds.

>> That would make PHP a dependency to build PHP, but it would hardly be
>> the first language which is reliant on itself to be built. Are there
>=20
> It would not be the first, but why do it? It works just fine right =
now,
> why break it?

The advantages are twofold:

1. We avoid git tracking generated files that don=92t provide meaningful =
diffs and that can have massive changes just from changing the source =
code or the generation script.

2. It=92s no longer necessary to manually generate the VM every time an =
opcode is modified. (Less debugging pain if you forget.)

>=20
>> any distributions out there in which PHP is not available?
>=20
> There are systems that aren't Linux and don't have PHP as standard
> package, yes.

OK, that=92s true. But on such systems the release package would still =
build.

--
Andrea Faulds
http://ajf.me/