Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:76884
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.44 as permitted sender)
MIME-Version: 1.0
Date: Tue, 26 Aug 2014 21:55:34 +0200
Message-ID: <CAF+90c9b6aRNNvJ6QVmumGgBW8=+dPxiByYY0h8M6x+L+BrYWQ@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11340428c8166005018dafa3
Subject: Remove generated lexers from git?
From: nikita.ppv@gmail.com (Nikita Popov)

--001a11340428c8166005018dafa3
Content-Type: text/plain; charset=UTF-8

Hi internals!

Currently our git repo contains files like zend_language_scanner.c,
zend_ini_scanner.c, etc which are files generated by re2c. Historically
these files have been included because re2c was not readily available on
many platforms. In the thread on bison 3 compatibility [1] there was some
discussion as to whether this limitation still applies. Quoting Adam Harvey:

> +1. I don't think re2c is that onerous a requirement anyway, for the
> most part: it's available through apt-get, brew, yum, and probably
> most other packaging systems. Given the amount of other things a
> developer has to install to build php-src from git, re2c is hardly
> going to break the camel's back.

So, I'd like to bring this up again. Are there any objections to removing
generated lexer files from the repo? If not, does it suffice to just git rm
them and add them to .gitignore, or are other changes required?

Nikita

[1]: http://markmail.org/message/x3p7ltekzws6ywhw

--001a11340428c8166005018dafa3--