Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:76853
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.177 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEZPtU7Y6S9U+P_KEOhDJ-g12CihrOmoqFMpQnGUGLhp90r9qA@mail.gmail.com>
References: <CAEZPtU5_Gv+=R26b+wFMuwe6gxPXtKpdgQsaoV=Y0ON+tzfoXg@mail.gmail.com>
	<437C0D23-0519-4EA1-BBEB-A74C7C70A10E@rouvenwessling.de>
	<CAEZPtU7Y6S9U+P_KEOhDJ-g12CihrOmoqFMpQnGUGLhp90r9qA@mail.gmail.com>
Date: Mon, 25 Aug 2014 11:22:57 +0400
Message-ID: <CA+9eiLu_onnG136CunB8bfAWs--xPwaO70EbeZb3jPwqjrg7Cg@mail.gmail.com>
To: Pierre Joye <pierre.php@gmail.com>
Cc: =?UTF-8?Q?Rouven_We=C3=9Fling?= <me@rouvenwessling.de>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e013c6eca5a955a05016f0eb6
Subject: Re: [PHP-DEV] Naming issues, solutions
From: dmitry@zend.com (Dmitry Stogov)

--089e013c6eca5a955a05016f0eb6
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Pierre,

I'm glad, you agree to rename IS_INT back to IS_LONG.

zend_long and size_t usage looks fine.

I see no problems changing zend_string related API and related macros
introduced in NG. They are new for everyone.
I hope, the changes won't make API less clear or useful (so it would be
great to review them).

I don't see a big reason to rename "zend_uint" into "uint32_t", but it's
just my own opinion. I would prefer keep it as is, or at worse case rename
into "zend_uint32" or "uint32". Anyway, I'll agree with majority.

How are we going to proceed?
Do you like voting in https://wiki.php.net/rfc/better_type_names_for_int64
or you may just revert part of the int64 patch related to IS_LONG -> IS_INT
renaming?

Who is going to implement the rest? When? Do we need RFC?
May be it should be a general RFC about internal PHP APIs cleanup?
I know, there are a lot of other inconsistencies...

Thanks. Dmitry.


On Sun, Aug 24, 2014 at 5:21 PM, Pierre Joye <pierre.php@gmail.com> wrote:

> On Sun, Aug 24, 2014 at 3:20 PM, Rouven We=C3=9Fling <me@rouvenwessling.d=
e>
> wrote:
> >
> >
> >> Am 24.08.2014 um 14:30 schrieb Pierre Joye <pierre.php@gmail.com>:
> >>
> >> zend_uint     > int32_t
> >
> > Is that a typo? If it's not, why are you changing it to signed?
>
> typo. It should be:
>
> zend_uint > uint32_t
>
> Thanks :)
>
> > Best regards
> > Rouven
>
>
>
> --
> Pierre
>
> @pierrejoye | http://www.libgd.org
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--089e013c6eca5a955a05016f0eb6--