Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:76833
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.173 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <e0768962293daa3b4e5a5784ce3646b9.squirrel@webmail.klapt.com>
References: <CAF+90c_AMJ3SLyX7eDQq-gwFLOCQUfLus+qFfJgAgTzBpZpfEg@mail.gmail.com>
	<e0768962293daa3b4e5a5784ce3646b9.squirrel@webmail.klapt.com>
Date: Sat, 23 Aug 2014 13:43:48 +0400
Message-ID: <CA+9eiLsW4OBfj90mzZuW=HKstcLjfVbXQB5dfcm9sj8WrOF7zg@mail.gmail.com>
To: Anatol Belski <anatol.php@belski.net>
Cc: Nikita Popov <nikita.ppv@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=20cf3030c11f6a9363050148ca34
Subject: Re: [PHP-DEV] [RFC] Better type names for int64 RFC
From: dmitry@zend.com (Dmitry Stogov)

--20cf3030c11f6a9363050148ca34
Content-Type: text/plain; charset=UTF-8

I think it's ok to keep zend_off_t and zend_size_t as is.

Thanks. Dmitry,


On Fri, Aug 22, 2014 at 4:09 PM, Anatol Belski <anatol.php@belski.net>
wrote:

> Hi Nikita,
>
> On Fri, August 22, 2014 13:16, Nikita Popov wrote:
> > Hi internals!
> >
> >
> > Today the int64 RFC has been merged, despite objections regarding the
> > naming changes it introduces.
> >
> > As we were not given a chance to resolve this issue before the merge, a
> > short proposal has been created, which aims to revert all unnecessary
> > naming changes and instead use type names that are consistent with the
> > existing code base and expectations:
> >
> > https://wiki.php.net/rfc/better_type_names_for_int64
> >
> >
> > Due to the unexpected merge on short notice, with no chance for
> > discussion, this issue is blocking a number of other patches. As such I
> > ask if we can move through this RFC with a shortened cycle. I would not
> > appreciate having to wait three weeks to have a workable codebase again.
> >
> > Nikita
> >
> to be complete, the RFC probably should take in account several new
> identifiers which came in (zend_off_t, zend_stat_t and co.). As their
> naming scheme is probably somewhat different. I've just documented those
> http://git.php.net/?p=php-src.git;a=blob;f=UPGRADING.INTERNALS and
> continue.
>
> Regards
>
> Anatol
>
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--20cf3030c11f6a9363050148ca34--