Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:76793
Return-Path: <ab@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 40328 invoked from network); 22 Aug 2014 08:57:08 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 22 Aug 2014 08:57:08 -0000
Authentication-Results: pb1.pair.com smtp.mail=ab@php.net; spf=unknown; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=ab@php.net; sender-id=unknown
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.73.107 as permitted sender)
X-PHP-List-Original-Sender: ab@php.net
X-Host-Fingerprint: 85.214.73.107 klapt.com  
Received: from [85.214.73.107] ([85.214.73.107:41894] helo=h1123647.serverkompetenz.net)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id BA/66-09530-ED507F35 for <internals@lists.php.net>; Fri, 22 Aug 2014 04:57:08 -0400
Received: by h1123647.serverkompetenz.net (Postfix, from userid 33)
	id 7211D6D209C; Fri, 22 Aug 2014 10:56:59 +0200 (CEST)
Received: from 79.197.90.39
        (SquirrelMail authenticated user anatol@belski.net)
        by webmail.klapt.com with HTTP;
        Fri, 22 Aug 2014 10:56:59 +0200
Message-ID: <22b71e9abe00bba8f6e2f9d73dd441e9.squirrel@webmail.klapt.com>
In-Reply-To:
 <CA+9eiLt7-a9vA-s2b7KymFLkGvFEW5rXJV5n3pMmkS+xxU6-qQ@mail.gmail.com>
References:
    <CA+9eiLt7-a9vA-s2b7KymFLkGvFEW5rXJV5n3pMmkS+xxU6-qQ@mail.gmail.com>
Date: Fri, 22 Aug 2014 10:56:59 +0200
To: "Dmitry Stogov" <dmitry@zend.com>
Cc: "PHP Internals" <internals@lists.php.net>,
 "Pierre Joye" <pierre.php@gmail.com>,
 "Anatol Belski" <ab@php.net>
Reply-To: "Anatol Belski" <ab@php.net>
User-Agent: SquirrelMail/1.5.2 [SVN]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] 64-bit integers and 64-bit string length patch is
 ready to be merged
From: ab@php.net ("Anatol Belski")

Moin,

On Thu, August 21, 2014 19:23, Dmitry Stogov wrote:
> Hi,
>
>
> Thanks to Anatol and Pierre the 64-bit patch is ready
> https://github.com/weltling/php-src
>
>
> I made quick code review and don't see any technical problems now.
>
>
> The performance and memory consumption difference is negligible. see
> https://docs.google.com/spreadsheets/d/1PD4oiiXz6B0JbeZYnUSat5fHoq3_jAiCeI
> 2cGHJ3UtQ/edit#gid=0
>
>
> The patch breaks one test on 32-bit Linux:
> ext/date/tests/bug53437_var3.phpt (seems to be a bogus test and wrong
> behavior in php5.6 and below) and one test on 64-bit Linux:
> ext/standard/tests/array/array_pad_variation2.phpt (has to be analyzed)
>
> The only thing that I don't like is a massive renaming described here
> https://wiki.php.net/rfc/size_t_and_int64_next#semantical_macro_renamings
>
>
> IS_LONG -> IS_INT
> Z_LVAL -> L_IVAL
> etc
>
> On one hand using INT may be more consistent, on the other hand it's
> going to break habits and make addition headache for merging from php-5 (I
> know, phpng already made problems)
>
> I'm not sure how to proceed. If I'm alone, lets go ahead with new names.
> If
> some others prefer old names we will probably need voting.
>
> Despite of renaming, I would like to see this patch in master ASAP.
>
>
> Thanks. Dmitry.
>
>

the patch is merged by now as is. I greatefuly thank all the supporters,
especially Nikita for the idea on how to join phpng and str-size_and_int64
with minimal loss and Dmitry for the closer look. I think it's feasible
solving the naming issues with Andrea's or some separate RFC.

Regards

anatol