Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:76766
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.179 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEZPtU4WKCqvFG-xHXZwBN+A2fLOtkH2g81uUL6k95wWhnf39A@mail.gmail.com>
References: <CA+9eiLt7-a9vA-s2b7KymFLkGvFEW5rXJV5n3pMmkS+xxU6-qQ@mail.gmail.com>
	<6E03BE65-260C-4B94-9587-C785FBC112C2@ajf.me>
	<CAEZPtU6ADFRd4JekU_PuCNWAZHN3y28tNR-9XUmJ+qnGOn8T7Q@mail.gmail.com>
	<75F705FC-178D-4CA4-A2ED-4FAD81A22F23@ajf.me>
	<CAEZPtU4WKCqvFG-xHXZwBN+A2fLOtkH2g81uUL6k95wWhnf39A@mail.gmail.com>
Date: Thu, 21 Aug 2014 22:14:38 +0400
Message-ID: <CA+9eiLv8VAjRNZW=onanPqUQyLfZ_Wa=KffCfNL800NeHtgWMA@mail.gmail.com>
To: Pierre Joye <pierre.php@gmail.com>
Cc: Andrea Faulds <ajf@ajf.me>, PHP internals <internals@lists.php.net>, Anatol Belski <ab@php.net>
Content-Type: multipart/alternative; boundary=bcaec52d57199b8664050127b174
Subject: Re: [PHP-DEV] 64-bit integers and 64-bit string length patch is ready
 to be merged
From: dmitry@zend.com (Dmitry Stogov)

--bcaec52d57199b8664050127b174
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Pierre, wait a day, and if we won't have many developers, who against the
new names - commit it as is.

Thanks. Dmitry.


On Thu, Aug 21, 2014 at 10:03 PM, Pierre Joye <pierre.php@gmail.com> wrote:

>
> On Aug 21, 2014 7:58 PM, "Andrea Faulds" <ajf@ajf.me> wrote:
> >
> >
> > On 21 Aug 2014, at 18:56, Pierre Joye <pierre.php@gmail.com> wrote:
> >
> > > The original patch used the right naming based on the type used behin=
d
> it.
> >
> > So IS_LONGLONG, then?
>
> The original patch, the one from last year. We have made compromises to
> fulfill other devs requests, three times.
>
> Now to be honest I would merge it right away. I do not see why we need to
> discuss that again. When I see how phpng got accepted without a word, tim=
e
> to stop arguing about such things. Merge and move back to code. If one
> thinks that one thing or another should be changed, in this patch or phpn=
g,
> he will need to write a rfc (and not in 6 months :).
>
> > > In any case, the patch represents what the rfc and the discussions
> around
> > > it say. I rather merge it asal and begin on the (long) list of todos
> for 7.
> > >
> > > If you like to propose new naming with the bigint rfc, please go ahea=
d.
> > > Time is also an issue as ppl are beginning to migrate their extension=
s
> to
> > > test. Changing them again takes time.
> >
> > Forgive me if I=E2=80=99m wrong, but wouldn=E2=80=99t changing the name=
 again just be a
> simple matter of global find/replace?
>
> No, totally not :)
>
> Even less as bigint support should be added too. And if bigint support
> will be optional, the code will need more changes.
>

--bcaec52d57199b8664050127b174--