Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:76761
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.53 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <75F705FC-178D-4CA4-A2ED-4FAD81A22F23@ajf.me>
References: <CA+9eiLt7-a9vA-s2b7KymFLkGvFEW5rXJV5n3pMmkS+xxU6-qQ@mail.gmail.com>
	<6E03BE65-260C-4B94-9587-C785FBC112C2@ajf.me>
	<CAEZPtU6ADFRd4JekU_PuCNWAZHN3y28tNR-9XUmJ+qnGOn8T7Q@mail.gmail.com>
	<75F705FC-178D-4CA4-A2ED-4FAD81A22F23@ajf.me>
Date: Thu, 21 Aug 2014 20:03:26 +0200
Message-ID: <CAEZPtU4WKCqvFG-xHXZwBN+A2fLOtkH2g81uUL6k95wWhnf39A@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: Dmitry Stogov <dmitry@zend.com>, PHP internals <internals@lists.php.net>, Anatol Belski <ab@php.net>
Content-Type: multipart/alternative; boundary=001a113a09e888c1be05012789ae
Subject: Re: [PHP-DEV] 64-bit integers and 64-bit string length patch is ready
 to be merged
From: pierre.php@gmail.com (Pierre Joye)

--001a113a09e888c1be05012789ae
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Aug 21, 2014 7:58 PM, "Andrea Faulds" <ajf@ajf.me> wrote:
>
>
> On 21 Aug 2014, at 18:56, Pierre Joye <pierre.php@gmail.com> wrote:
>
> > The original patch used the right naming based on the type used behind
it.
>
> So IS_LONGLONG, then?

The original patch, the one from last year. We have made compromises to
fulfill other devs requests, three times.

Now to be honest I would merge it right away. I do not see why we need to
discuss that again. When I see how phpng got accepted without a word, time
to stop arguing about such things. Merge and move back to code. If one
thinks that one thing or another should be changed, in this patch or phpng,
he will need to write a rfc (and not in 6 months :).

> > In any case, the patch represents what the rfc and the discussions
around
> > it say. I rather merge it asal and begin on the (long) list of todos
for 7.
> >
> > If you like to propose new naming with the bigint rfc, please go ahead.
> > Time is also an issue as ppl are beginning to migrate their extensions
to
> > test. Changing them again takes time.
>
> Forgive me if I=E2=80=99m wrong, but wouldn=E2=80=99t changing the name a=
gain just be a
simple matter of global find/replace?

No, totally not :)

Even less as bigint support should be added too. And if bigint support will
be optional, the code will need more changes.

--001a113a09e888c1be05012789ae--