Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:76727 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 87442 invoked from network); 20 Aug 2014 10:08:51 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Aug 2014 10:08:51 -0000 Authentication-Results: pb1.pair.com header.from=dmitry@zend.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=dmitry@zend.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.170 as permitted sender) X-PHP-List-Original-Sender: dmitry@zend.com X-Host-Fingerprint: 209.85.220.170 mail-vc0-f170.google.com Received: from [209.85.220.170] ([209.85.220.170:63168] helo=mail-vc0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 8A/22-11231-1B374F35 for ; Wed, 20 Aug 2014 06:08:49 -0400 Received: by mail-vc0-f170.google.com with SMTP id lf12so8896736vcb.29 for ; Wed, 20 Aug 2014 03:08:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=0c1JcOgao+m2NctfluQIBVqx+C+nieD9UEqbeBS91QA=; b=FJmQjMkFmByXWjgwVPqnw88Tr3NUEAXSlCKx8+zdFLGGt3DQnYE2c89fxhOuNfvXqw V69MxvumXlAEb02MJUY4zcC7ddu1mWAfHjvpAWwNjv2E7+NblabGfu7GTROBQW4WLwjI OpMaQXMrQVhVi11SSRIdMDj0w7iUGiMlg47BPF3/ykNFLqPN0UwOYFHTT/1JFsYXNiXz iwN4o5w7+Wq3OK/Dh6jPQqYNeE6ScAtlufOaBL8VAEVICab5mXyOexCu9gnMxDPkWNpf GJrqwpx+NFwI4F+GP2oQIqW4IZ3P2m2Oqsi5JePsv0MORK/Cfeo6cqAtPHZWRjdBI4gB kdDw== X-Gm-Message-State: ALoCoQngTzY4xqSHFU7KuLFpazTV6zrNIOhJ/ZzkPNU4WjnEudpxDYn0pZkp6nV+nLoFNh1Jh0iZ5lBIWwD+TVlDWeb18gSnBEgZ5F36fZr7y/PdoQ56MF+KDrO58bmmXAM2PgwqJzWN MIME-Version: 1.0 X-Received: by 10.220.30.8 with SMTP id s8mr728985vcc.58.1408529326517; Wed, 20 Aug 2014 03:08:46 -0700 (PDT) Received: by 10.52.110.170 with HTTP; Wed, 20 Aug 2014 03:08:46 -0700 (PDT) In-Reply-To: References: Date: Wed, 20 Aug 2014 14:08:46 +0400 Message-ID: To: Julien Pauli Cc: Laruence , Nikita Popov , PHP Internals Content-Type: multipart/alternative; boundary=001a11c2d05629c97a05010ccaa8 Subject: Re: [PHP-DEV] ext/standard/tests/http/bug60570.phpt failure From: dmitry@zend.com (Dmitry Stogov) --001a11c2d05629c97a05010ccaa8 Content-Type: text/plain; charset=UTF-8 The are not defined. They are open (or closed but not freed yet). You probably meant get_defined_resorce_types() Thanks. Dmitry. On Wed, Aug 20, 2014 at 1:12 PM, Julien Pauli wrote: > On Wed, Aug 20, 2014 at 7:24 AM, Dmitry Stogov wrote: > > Anyone objects about it or thinks it needs RFC? > > > > Thanks. Dmitry. > > > > > > On Wed, Aug 20, 2014 at 6:48 AM, Laruence wrote: > > > >> Hey: > >> > >> > >> On Tue, Aug 19, 2014 at 10:10 PM, Dmitry Stogov > wrote: > >> > Hi, > >> > > >> > Yesterday we discussed with Nikta the failure of > >> > ext/standard/tests/http/bug60570.phpt. It was in context of AST patch, > >> but > >> > the failure is not related to AST at all. It's just a bad test that > makes > >> > wrong assumption. > >> > > >> > Resource leaks can't be caught using get_memory_usage(). > >> > > >> > To have a robust way to detect resource leaks I propose a new > function - > >> > get_resources() that returns an array of all registered resources or > an > >> > array of registered resources of particular type. See patch: > >> > > >> > https://gist.github.com/dstogov/f96c04f5979e726909ab > >> > > >> > I'm not sure if such small change needs RFC. > >> > > >> > Thoughts? > >> I think it's okey to have a such function. > >> > >> we have get_defined_functions/constants/vars > >> > >> thanks > > I would have then called it get_defined_resources() , for consistency. > > Julien.P > --001a11c2d05629c97a05010ccaa8--