Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:76720
Return-Path: <julienpauli@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 73035 invoked from network); 20 Aug 2014 09:13:30 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 20 Aug 2014 09:13:30 -0000
Authentication-Results: pb1.pair.com header.from=julienpauli@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=julienpauli@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.171 as permitted sender)
X-PHP-List-Original-Sender: julienpauli@gmail.com
X-Host-Fingerprint: 209.85.220.171 mail-vc0-f171.google.com  
Received: from [209.85.220.171] ([209.85.220.171:44456] helo=mail-vc0-f171.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 1F/80-03084-8B664F35 for <internals@lists.php.net>; Wed, 20 Aug 2014 05:13:28 -0400
Received: by mail-vc0-f171.google.com with SMTP id hq11so8861930vcb.30
        for <internals@lists.php.net>; Wed, 20 Aug 2014 02:13:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:in-reply-to:references:from:date:message-id
         :subject:to:cc:content-type;
        bh=PystYSrD8hLvkp4BOOAWDexf6BThOQg43nb4CVPnVLw=;
        b=0kliud8wr6hJ/8jaebSCTDsKSXYx89ch2KO8X0FfSkuuIumz+XfRmnonx3m5lQxVxq
         Ov8dVy28IKXIlZ/7cBn25Dtvhi2R2Ghmz9s7KLqfB3BRkWY+OfsjiL72xJ061A3NuAKo
         IS00Kh+JMNj6t+sMKYLlpQafUSWP2Y8H599139sYkyTDMgbMHAaBOBUcp/Y6d25JKq9T
         ebasM3NkhhNI3m6NVgxuSWiR5VN/30cA8beWIr/vmBr86zJ292+SYVw13e7GftIaCU6h
         vnC6uoUCapSemt8uA9P3ssy91LC8FavSam6NhTu5XXd0QFtHVo+scGI6BoE9oodCrDIt
         qdNw==
X-Received: by 10.220.130.131 with SMTP id t3mr35395771vcs.30.1408526005486;
 Wed, 20 Aug 2014 02:13:25 -0700 (PDT)
MIME-Version: 1.0
Sender: julienpauli@gmail.com
Received: by 10.220.30.70 with HTTP; Wed, 20 Aug 2014 02:12:45 -0700 (PDT)
In-Reply-To: <CA+9eiLse-Jt72Mt335A1wz1ajwU-5eGrNb3pHOr+ekwOtjMnQA@mail.gmail.com>
References: <CA+9eiLuvyBX8n9AsGGv=PAJAedaHxxCvpCa4F6nTThUNMJC8fw@mail.gmail.com>
 <CABBJUpe3qjSJmwUgxwnX7i30cP8UVN_MfKZvLsCgRqU17XeL9Q@mail.gmail.com> <CA+9eiLse-Jt72Mt335A1wz1ajwU-5eGrNb3pHOr+ekwOtjMnQA@mail.gmail.com>
Date: Wed, 20 Aug 2014 11:12:45 +0200
X-Google-Sender-Auth: A7GT0DatZ0dlnkFO_yJFORwFK7k
Message-ID: <CAMUwpuQeX8iD1xr-p=v-kmx1GK6-A-w++nV9u46Low1YX1qULA@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: Laruence <laruence@php.net>, Nikita Popov <nikita.ppv@gmail.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] ext/standard/tests/http/bug60570.phpt failure
From: jpauli@php.net (Julien Pauli)

On Wed, Aug 20, 2014 at 7:24 AM, Dmitry Stogov <dmitry@zend.com> wrote:
> Anyone objects about it or thinks it needs RFC?
>
> Thanks. Dmitry.
>
>
> On Wed, Aug 20, 2014 at 6:48 AM, Laruence <laruence@php.net> wrote:
>
>> Hey:
>>
>>
>> On Tue, Aug 19, 2014 at 10:10 PM, Dmitry Stogov <dmitry@zend.com> wrote:
>> > Hi,
>> >
>> > Yesterday we discussed with Nikta the failure of
>> > ext/standard/tests/http/bug60570.phpt. It was in context of AST patch,
>> but
>> > the failure is not related to AST at all. It's just a bad test that makes
>> > wrong assumption.
>> >
>> > Resource leaks can't be caught using get_memory_usage().
>> >
>> > To have a robust way to detect resource leaks I propose a new function -
>> > get_resources() that returns an array of all registered resources or an
>> > array of registered resources of particular type. See patch:
>> >
>> > https://gist.github.com/dstogov/f96c04f5979e726909ab
>> >
>> > I'm not sure if such small change needs RFC.
>> >
>> > Thoughts?
>> I think it's okey to have a such function.
>>
>> we have get_defined_functions/constants/vars
>>
>> thanks

I would have then called it get_defined_resources() , for consistency.

Julien.P