Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:76682
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.169 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAFMT4NrmT3r1B6nt8OoaFJWtETBO=jCCAJNJGUYk8J1mOvhjNw@mail.gmail.com>
References: <CA+9eiLur_OkkbEC=gMHqX++mnA2rfYSm_m6i3NO=r=MvgU6Aww@mail.gmail.com>
	<E90D5EFF-ADAB-4DE3-AD26-5819D6CA993D@ajf.me>
	<CA+9eiLsfOaY7yw3d3X2=_nQFS4sp5BK=oo_98t_1_mR8pTEc0Q@mail.gmail.com>
	<CAFMT4NpbsoU5rLNJo_dxTpcfc186yUn8a1i8BR4q+nthYXMRig@mail.gmail.com>
	<CA+9eiLu91N_jrD+=YT89gwKcx8ZQ0QHb-4fPYVtte9GmaKJxTQ@mail.gmail.com>
	<CAFMT4NrmT3r1B6nt8OoaFJWtETBO=jCCAJNJGUYk8J1mOvhjNw@mail.gmail.com>
Date: Tue, 19 Aug 2014 09:50:17 +0400
Message-ID: <CA+9eiLur8HwFW1DF7Ok=-QmgPRB4RiYY2q6aB-UFgdWerb3HEw@mail.gmail.com>
To: Levi Morrison <morrison.levi@gmail.com>
Cc: Andrea Faulds <ajf@ajf.me>, Joe Watkins <krakjoe@php.net>, ircmaxell@php.net, 
	Nikita Popov <nikic@php.net>, Xinchen Hui <xinchen.h@zend.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1133ececef532a0500f50f1b
Subject: Re: Optional Type Hinting
From: dmitry@zend.com (Dmitry Stogov)

--001a1133ececef532a0500f50f1b
Content-Type: text/plain; charset=UTF-8

The patch looks good and seems to contain the necessary opcache changes.

I'm not sure if you really need zend_return_hint.used and
zend_return_hint.class_name_type (may be I just didn't analyze the patch
deep enough).

You may support "self" by setting  zend_return_hint.class_name =
GC(actrive_class_entry)->name.
If return type hinting is unused then zend_function. return_hint should be
NULL

In PHP7 it may make sense to embed fields of zend_return_hint (zend_string
return_class_name and zend_uchar return_type) directly into zend_function.
It may keep the same memory usage for cases without return type hinting and
decrease it with return type hinting.

Thanks. Dmitry.


On Tue, Aug 19, 2014 at 8:23 AM, Levi Morrison <morrison.levi@gmail.com>
wrote:

> On Mon, Aug 18, 2014 at 1:43 PM, Dmitry Stogov <dmitry@zend.com> wrote:
> > Hi Levi,
> >
> > The implementation is really not a problem. It must be quite simple and I
> > may take care about it.
> > The problem that we can't come to agreement on scalar type hinting for
> years
> > :(
> >
> > Thanks. Dmitry.
> >
> >
> > On Mon, Aug 18, 2014 at 9:57 PM, Levi Morrison <morrison.levi@gmail.com>
> > wrote:
> >>
> >> On Mon, Aug 18, 2014 at 8:21 AM, Dmitry Stogov <dmitry@zend.com> wrote:
> >> > I see your point. For me they just don't have a lot of sense without
> >> > each
> >> > other.
> >>
> >> I am the author of two of those RFCs. I've worked with several members
> >> of the HHVM team so that any inconsistencies are planned and recorded
> >> (or will be; I know of one inconsistency in return types that is not
> >> currently recorded).
> >>
> >> I also am definitely not in favor of merging them, for the reasons
> >> Andrea outlined.
> >>
> >> Also, Dmitry, if you have interest in working on the implementations
> >> for these RFCs I'm sure Joe would appreciate the help (I know I
> >> would).
>
> Joe was able to get it mostly completed in a really short period of
> time, but there is some issue going on with opcache. I have forgotten
> the details now, but I think it had to deal with the fact that the
> types need to have delayed binding. Joe or Anthony, can you maybe give
> more information here?
>
> Additionally, the implementation was built off of master because it
> was created before PHPNG; I think I probably want to target PHP 7
> instead of 5.7 (again, PHP 7 was only being dreamed of then) so it
> would need rebased at least. Here's the work by Joe and Anthony:
> https://github.com/krakjoe/php-src/compare/returntypehinting
>

--001a1133ececef532a0500f50f1b--