Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:76639
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.179 as permitted sender)
MIME-Version: 1.0
Sender: julienpauli@gmail.com
In-Reply-To: <53F1094B.4040100@mabe.berlin>
References: <53F1094B.4040100@mabe.berlin>
Date: Mon, 18 Aug 2014 11:57:53 +0200
Message-ID: <CAMUwpuR6dDbefL0QaKJ2ewHJXOgqugdvkXdRacaPx423+zKhMg@mail.gmail.com>
To: Marc Bennewitz <php@mabe.berlin>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC] Binary String Comparison
From: jpauli@php.net (Julien Pauli)

On Sun, Aug 17, 2014 at 9:58 PM, Marc Bennewitz <php@mabe.berlin> wrote:
> Hi internals!
>
> I've created a draft RFC and patch to change the behavior of non-strict
> string to string comparison to be binary safe (as the strict comparison
> operator does):
>
>      https://wiki.php.net/rfc/binary_string_comparison
>
> On comparing two numeric strings both operands will be equal if the string
> representation will be the same. On comparing two numeric strings the first
> operand will be greater if the first not matching byte will be higher. On
> comparing two numeric strings the first operand will be lower if the first
> not matching byte will be lower.
>
> As a side effect it makes string comparison much faster and force developer
> to really write what they mean (No need to guess) and to force developers to
> cast/filter input once which also affects performance.
>
> On C-Level the function zendi_smart_strcmp will be unused and marked as
> deprecated.
>
> Thanks,
> Marc

This seems to me as a major breakage, not necessary, as strict
comparison (===) or strcmp() are available.

Julien Pauli