Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:76627
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.182 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <327540B4-FF52-4F60-ABFF-255B8B514C14@ajf.me>
References: <327540B4-FF52-4F60-ABFF-255B8B514C14@ajf.me>
Date: Mon, 18 Aug 2014 09:36:07 +0400
Message-ID: <CA+9eiLvhwa-PtPqVcL-HByinEhjQpADqwbB5JgSVNpgjyy38CA@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1135f63c67e56e0500e0bf36
Subject: Re: [PHP-DEV] phpng parameter parsing bug
From: dmitry@zend.com (Dmitry Stogov)

--001a1135f63c67e56e0500e0bf36
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Thanks for catching this. I'm fixing it.

Dmitry.


On Mon, Aug 18, 2014 at 5:57 AM, Andrea Faulds <ajf@ajf.me> wrote:

> Hi!
>
> In _z_param_long in Zend/zend_API.h:
>
>         if (EXPECTED(Z_TYPE_P(arg) =3D=3D IS_LONG)) {
>                 if (strict && UNEXPECTED(Z_DVAL_P(arg) > LONG_MAX)) {
>                         *dest =3D LONG_MAX;
>                 } else if (strict && UNEXPECTED(Z_DVAL_P(arg) < LONG_MIN)=
)
> {
>                         *dest =3D LONG_MIN;
>                 } else {
>                         *dest =3D Z_LVAL_P(arg);
>                 }
>
> Note that it=E2=80=99s interpreting a long argument as a double. I expect=
 this
> will probably go horribly, horribly wrong.
>
> I don=E2=80=99t have /Zend karma (yet!), could this be fixed?
>
> Thanks!
> --
> Andrea Faulds
> http://ajf.me/
>
>
>
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--001a1135f63c67e56e0500e0bf36--