Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:76527
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lerdorf.com from 209.85.216.47 cause and error)
Message-ID: <53ED35C4.6070001@lerdorf.com>
Date: Thu, 14 Aug 2014 18:18:44 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0
MIME-Version: 1.0
To: PHP internals <internals@lists.php.net>
CC: Keyur Govande <keyurgovande@gmail.com>
References: <CAJhmKHn+3NDLv7rh5Be9HHZCi0QmeuExpG7qBJh9uES86MTZPg@mail.gmail.com>
In-Reply-To: <CAJhmKHn+3NDLv7rh5Be9HHZCi0QmeuExpG7qBJh9uES86MTZPg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [PATCH] Fixes for bugs #65463, #66036
From: rasmus@lerdorf.com (Rasmus Lerdorf)

On 08/14/2014 01:43 PM, Keyur Govande wrote:
> Hello,
> 
> I've opened https://github.com/php/php-src/pull/770 for patches for bugs
> #65463, #66036. More details in the PR.
> 
> The bug is reproducible on PHP 5.4, 5.5 and 5.6 with and without
> --enable-zend-signals.
> 
> Please review, I'm hesitant to merge such a core change without more eyes.

The patch is simple enough and it has been running in production at Etsy
for quite a while now. But we have had shutdown order issues since
forever and I have lost track of all the various nuances of this
problem. As far as I can tell this doesn't cause any additional problems
and fixes an obvious and common segfault.

-Rasmus