Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:76400 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 89695 invoked from network); 6 Aug 2014 15:52:07 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Aug 2014 15:52:07 -0000 Authentication-Results: pb1.pair.com smtp.mail=tyra3l@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=tyra3l@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.46 as permitted sender) X-PHP-List-Original-Sender: tyra3l@gmail.com X-Host-Fingerprint: 209.85.216.46 mail-qa0-f46.google.com Received: from [209.85.216.46] ([209.85.216.46:49020] helo=mail-qa0-f46.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 10/B3-02707-72F42E35 for ; Wed, 06 Aug 2014 11:52:07 -0400 Received: by mail-qa0-f46.google.com with SMTP id v10so2670641qac.33 for ; Wed, 06 Aug 2014 08:52:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Q4vN7A0XKxvOrNoGsbT7Nn4sfwC1fHBgW2ag2cwFK/o=; b=dzpyTrxOTf1aBbzWCMddCXs1UVEQGfN+ize5K0uXR5l66BnxhgrWmBXp7GprqXo3Xy j91ou6Kt0XiNatpp/LWYhnKPahp3NTrDUaOJTLg7Du5P5QO+GO+FxSMFHCsr/flwgtUR rnHg+WPzOGUICRlWJf9jle1VmzOMShaBjLon3X01Kw14rqmItfWOyy5Ni1Hq8SRh15Ld T8rQU6I4SAfqhnoau1actPEAjDhUZ7447z0F3L9Tw1ajGm93+hAwZnptXqmF6o/9nN2f 95TjtGTUYLTdXYwNE5sW/+gACL+ev20CD0RtIzq47aNPnWipV6WDUWaYlbvVM/vWJ2NM +MHw== MIME-Version: 1.0 X-Received: by 10.140.102.117 with SMTP id v108mr4476174qge.93.1407340355642; Wed, 06 Aug 2014 08:52:35 -0700 (PDT) Received: by 10.140.102.111 with HTTP; Wed, 6 Aug 2014 08:52:35 -0700 (PDT) In-Reply-To: References: <5a5c7d37c2115f52a58d82d489540a6d@mail.gmail.com> <79d5d0a1410487d543d37ba573b392a9@mail.gmail.com> Date: Wed, 6 Aug 2014 17:52:35 +0200 Message-ID: To: Dan Ackroyd Cc: Zeev Suraski , PHP internals Content-Type: multipart/alternative; boundary=001a11c16ec4f9eec504fff7f5e9 Subject: Re: [PHP-DEV] [VOTE] Move the phpng branch to master From: tyra3l@gmail.com (Ferenc Kovacs) --001a11c16ec4f9eec504fff7f5e9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, Aug 6, 2014 at 5:50 PM, Ferenc Kovacs wrote: > > > > On Wed, Aug 6, 2014 at 5:38 PM, Dan Ackroyd > wrote: > >> Hi Zeev, >> >> >I have no problem with changing this >> >habit, but I do have an issue with changing it retroactively for a >> >particular vote. >> >> Agreed, changing rules retroactively is bad. Considering improving >> practices for the future is good. >> >> >To your specific feedback, there's a migration document to extensions >> linked >> >from the RFC, and shared here on internals about 10 days ago: >> >> Thanks for that document. >> >> It would also be really useful if you could add a link to two commits >> of a non-trivial extension that has been migrated, with one commit >> before, and one commit after the migration. That would allow people >> like myself who only rarely dip into PHP internals to see the >> differences actually applied to code. >> > > git diff origin/master.. -- ext/curl (for example) > is this really something which you think most voters would have trouble > doing? > > -- > Ferenc Kov=C3=A1cs > @Tyr43l - http://tyrael.hu > git diff origin/master..origin/phpng -- ext/curl is slightly better as it works independently from the current checkout. --=20 Ferenc Kov=C3=A1cs @Tyr43l - http://tyrael.hu --001a11c16ec4f9eec504fff7f5e9--