Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:76393
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.48 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CA+9eiLsLD1grqKaTfpu+ZVA3wSxMX+Rrf+1fP3+DzpH3x_2VyQ@mail.gmail.com>
References: <5a5c7d37c2115f52a58d82d489540a6d@mail.gmail.com>
	<CA+kxMuThr-uSKbUu5TGRSqZzNrSKDYHL731Aq5huLCTCRF2i0w@mail.gmail.com>
	<79d5d0a1410487d543d37ba573b392a9@mail.gmail.com>
	<CA+9eiLsLD1grqKaTfpu+ZVA3wSxMX+Rrf+1fP3+DzpH3x_2VyQ@mail.gmail.com>
Date: Wed, 6 Aug 2014 15:26:08 +0200
Message-ID: <CAEZPtU5VMof7vRiB712EYZw9sXqAgc3ryoTPZnfntP7eymABHA@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: Zeev Suraski <zeev@zend.com>, Dan Ackroyd <danack@basereality.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [VOTE] Move the phpng branch to master
From: pierre.php@gmail.com (Pierre Joye)

On Wed, Aug 6, 2014 at 3:19 PM, Dmitry Stogov <dmitry@zend.com> wrote:
> On Wed, Aug 6, 2014 at 5:11 PM, Zeev Suraski <zeev@zend.com> wrote:
>
>> Dan,
>>
>> Votes area almost never pre-announced.  I have no problem with changing
>> this
>> habit, but I do have an issue with changing it retroactively for a
>> particular vote.
>>
>> Regarding your points, there's a mandatory discussion period during which
>> you should have brought these comments, instead of now.  As a matter of
>> fact, discussion about PHPNG died out more than a week ago, to the level
>> that Dmitry even suggested we avoid wasting time and vote sooner (but that
>> goes against the rules so we didn't do that).
>>
>> If you think the RFC is incomplete in its details and that you can't vote
>> over it then you can of course withhold your vote or vote no.
>>
>> To your specific feedback, there's a migration document to extensions
>> linked
>> from the RFC, and shared here on internals about 10 days ago:
>> https://wiki.php.net/phpng-upgrading
>> I added another link to it from the 'RFC impact' section, as perhaps that's
>> what prevented you from seeing it.
>>
>> I believe it's impractical to keep shared codebases for extensions between
>> PHP 5.x and PHPNG.  Dmitry - please correct me if I'm wrong...
>>
>
> Some extension might require just few changes and they may share codebase
> for PHP and PHPNG, however it's going to be really difficult for very
> engine depended extensions like xdebug.

For the exts I tried while I was testing/fixing phpng a couple of
weeks ago, I'd to say that maintaining the same code base for phpng
and 5.x is simply too hard, way too many APIs changes, many of them
cannot be detected at compile time, introducing many many new #ifdefs
along other things. I will maintain a separate branch. The only thing
I worry about is how I will manage releases in pecl. I have no clean
solution now, or maybe one release with two branches bundled. Separate
releases could work too but I will try everything possible to do not
have to do that, or to have to do that as it is really painful to do.
Maybe I can manage to implement something in pickle to ease this work.
Ideas welcome.

-- 
Pierre

@pierrejoye | http://www.libgd.org