Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:76260
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.178 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXZKnuq2a11E-25Vmc9Tq=utT1kJZ3BZzPWk2xFHzFX5Hw@mail.gmail.com>
References: <CAGa2bXZKnuq2a11E-25Vmc9Tq=utT1kJZ3BZzPWk2xFHzFX5Hw@mail.gmail.com>
Date: Wed, 30 Jul 2014 13:01:06 +0800
Message-ID: <CAHMUw2E-YRcU6_ntp7-prEV8=ZWwUsRZOOJ=S1uGbO_8bPAg-g@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e0103eeba2ee03f04ff620b53
Subject: Re: [PHP-DEV] signed long hash index for PHP7?
From: tjerk.meesters@gmail.com (Tjerk Meesters)

--089e0103eeba2ee03f04ff620b53
Content-Type: text/plain; charset=UTF-8

Hi,


On Wed, Jul 30, 2014 at 10:37 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> Hi all,
>
> Current Zend hash uses ulong for numeric array indexes.
> This causes bug #67693
>
> https://bugs.php.net/bug.php?id=67693
>
> Signed/unsigned mismatch is the root cause of this bug.
> Since PHP's int is signed by default, it might be better
> to change Zend hash index to signed long.
>

Instead of doing that, why not simply disallow negative array indices to be
used as integers?

In other words, negative indices are treated as if you had used strings so
that it doesn't upset the the last numeric index kept in the array
structure.

From what I can tell, it should be a pretty simply patch.

Thoughts?


>
> I would like to hear comments who understand Zend internals. If there
> aren't
> issues, we may have signed long index for PHP7.
>
> I also would like to hear comments for possible fix in released versions.
>
> Regards,
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net
>



-- 
--
Tjerk

--089e0103eeba2ee03f04ff620b53--