Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:76250 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 92857 invoked from network); 29 Jul 2014 08:44:00 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 29 Jul 2014 08:44:00 -0000 Authentication-Results: pb1.pair.com smtp.mail=julienpauli@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=julienpauli@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.169 as permitted sender) X-PHP-List-Original-Sender: julienpauli@gmail.com X-Host-Fingerprint: 209.85.220.169 mail-vc0-f169.google.com Received: from [209.85.220.169] ([209.85.220.169:34865] helo=mail-vc0-f169.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 8E/08-41808-ECE57D35 for ; Tue, 29 Jul 2014 04:43:59 -0400 Received: by mail-vc0-f169.google.com with SMTP id le20so4264810vcb.14 for ; Tue, 29 Jul 2014 01:44:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=2yqIqIH/YcPTwKiYyFyVUA869DQ9TMp3rgMkaLW8MXE=; b=B8ibOKMbNf5tvInAuIPwORmSBEayXlfnXRjy9mwr/5j2vDnF3Efsur8rJX7qmnZkgu X4UpWXpMbZEnnMtq8y4VXB6lOinXBSJ9yXhaL8Y1Q/7OpUj/zhXPyEN62xqOlHlbBff2 OpYCSFy5mHNTRYAIpWUuee7Bjl/vY7pf08qahjz7h2wROU5N+xORBqA2XneI/QuVfv1n fxqWUaS10SqmKv8s0+wl9XiO9KIF+JLz9h9KzY7DqchiESEOoe+FStYaZzRzaos/r3O/ 4u7+0qt4YEIuMGKrsRsxfI6caFA8J8TxKai9EOc0dUyf59rXBz7pVO1xfuYRQBxjDAeT S8DA== X-Received: by 10.221.41.135 with SMTP id tu7mr29583vcb.70.1406623450218; Tue, 29 Jul 2014 01:44:10 -0700 (PDT) MIME-Version: 1.0 Sender: julienpauli@gmail.com Received: by 10.220.81.68 with HTTP; Tue, 29 Jul 2014 01:43:29 -0700 (PDT) In-Reply-To: <53D751E1.5050400@sugarcrm.com> References: <53A3874E.20704@sugarcrm.com> <53A62AFF.4080302@sugarcrm.com> <53B10D59.4060206@sugarcrm.com> <53D751E1.5050400@sugarcrm.com> Date: Tue, 29 Jul 2014 10:43:29 +0200 X-Google-Sender-Auth: sufAW-NeDE0JZygDFzGBFcysDsM Message-ID: To: Stas Malyshev Cc: Ferenc Kovacs , Nikita Popov , Alexey Zakhlestin , Marco Pivetta , Sebastian Bergmann , Remi Collet , PHP Internals Content-Type: multipart/alternative; boundary=001a1133901c154a4004ff510b73 Subject: Re: [PHP-DEV] Problems with the fix for the BC break introduced in 5.4.29 and 5.5.13 From: jpauli@php.net (Julien Pauli) --001a1133901c154a4004ff510b73 Content-Type: text/plain; charset=UTF-8 On Tue, Jul 29, 2014 at 9:48 AM, Stas Malyshev wrote: > Hi! > > > What I found *not safe*, throwing unwanted warnings hitting an > > undesired behavior, or even segfaulting, and thus needing patch : > > - Dom > > - Mysqli > > - sqlite3 (sqlite3stmt class segfaults) > > I've fixed all the instances of problematic behavior with no ctor that I > could catch now. I could not reproduce problems in DOM or mysqli, so > it'd be nice to have reproductions there. Otherwise, I think the core > modules are fine in my tests. > Mmmm, I can't reproduce segfaults. I can only hit the check messages that check the instance is correctly constructed. When sqlite and SPL is patched, can we say we are safe about this issue ? For SPL, I have no deep knowledge about it, I couldn't find any bad behavior from my tests, all seemed to check the state, but I did not perform full 100% coverage tests. Thanks. Julien --001a1133901c154a4004ff510b73--