Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:76136 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 33355 invoked from network); 25 Jul 2014 19:22:36 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 Jul 2014 19:22:36 -0000 Authentication-Results: pb1.pair.com smtp.mail=tyra3l@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=tyra3l@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.42 as permitted sender) X-PHP-List-Original-Sender: tyra3l@gmail.com X-Host-Fingerprint: 209.85.216.42 mail-qa0-f42.google.com Received: from [209.85.216.42] ([209.85.216.42:48881] helo=mail-qa0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id CA/0A-08559-A7EA2D35 for ; Fri, 25 Jul 2014 15:22:34 -0400 Received: by mail-qa0-f42.google.com with SMTP id j15so5045621qaq.1 for ; Fri, 25 Jul 2014 12:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=K8i7rBmFb6yxWJiIuuDwzdbp2n3M4C07oq08za7DL1Y=; b=aXtzn4g35MZ3GcCSXPti0bTExdTZ/p1nAFY6vrecP3LlbGKFHbXr4o0oiN3uvQuPYs ZIVrmApuJ0O0QsoiQmPL/CHD3AWxfhtS1oFV8uvMNvSIRM5xQCYcVLYOdfK0EeG8aWxN D7IwaeoHzmQxxVFTRdZqq6TtGj0l7XI+PS1vOK7/AbPPPSxyK/NAcEkM3Af5Rzl1iZ0q iLJg4bOmMkdeoahje9InyZElRGQRyfCSGfeAvcU8xVTXQc0SS/nwST8uD7bWhWTYd/q2 D/zC6fDk6OkEluHOx7zSCQQM8+uiZzfGdLcHM57NmfEHmpgOB2WNGEWkAbaSgO9jlKFf tHVw== MIME-Version: 1.0 X-Received: by 10.140.106.74 with SMTP id d68mr29285509qgf.103.1406316158747; Fri, 25 Jul 2014 12:22:38 -0700 (PDT) Received: by 10.140.102.111 with HTTP; Fri, 25 Jul 2014 12:22:38 -0700 (PDT) In-Reply-To: References: <53D01C19.9050606@sugarcrm.com> Date: Fri, 25 Jul 2014 21:22:38 +0200 Message-ID: To: Bob Weinand Cc: Stas Malyshev , Dmitry Stogov , Nikita Popov , Julien Pauli , PHP Internals Content-Type: multipart/alternative; boundary=001a113b4ecc158db804ff097f2f Subject: Re: [PHP-DEV] Weird constant expression syntax and bug From: tyra3l@gmail.com (Ferenc Kovacs) --001a113b4ecc158db804ff097f2f Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, Jul 25, 2014 at 4:36 PM, Ferenc Kovacs wrote: > > > > On Wed, Jul 23, 2014 at 10:45 PM, Bob Weinand wrote= : > >> Am 23.7.2014 um 22:33 schrieb Stas Malyshev : >> > Hi! >> > >> >> It was a restriction to not support arrays in constant context. It >> seems >> >> like nobody can remember why it was introduced. >> > >> > My vague recollection is that it had some troubles with keeping >> > refcounts consistent, esp. withing bytecode caching context, but it ma= y >> > be a false memory :) >> >> That doesn't really make much sense to me, at least not with current >> engine... >> As said, I've tested it and didn't find issues. Maybe I just test the >> wrong things=E2=80=A6 >> >> >> However, I think it's too dangerous to break it in last minute before >> >> release. >> > >> > We definitely need to fix the WTF with "no runtime use" for defined >> > constant and the segfault before the release. I think for the arrays, = if >> > we can't have it working properly we'd better not have array support >> > there for 5.6.0 and fix it in 5.6.1 than have this weird "no runtime >> > use" thing. >> >> Well, we still could fix it now, AFAIK, we will still have another RC no= w >> and when we fix it only for 5.6.1, there also will only be one RC in >> between. >> That's no gain in testing time etc.. >> >> Bob >> >> > -- >> > Stanislav Malyshev, Software Architect >> > SugarCRM: http://www.sugarcrm.com/ >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> > yeah, there will be another RC for sure, but we have to have some > resulotion for that. > I think it would be safer to remove stuff (even if just the array support= ) > than trying to fix in in a hurry, as it would probably just cause shippin= g > the final with some other bug(s) or having a couple of other RCs. > nevermind, I've somehow missed https://github.com/php/php-src/commit/c49a06168ed3759779452e2b2a44da22e75a0= 702 and https://github.com/php/php-src/commit/d909b6330e314bb434350317fda5bec185ea1= 2c0 --=20 Ferenc Kov=C3=A1cs @Tyr43l - http://tyrael.hu --001a113b4ecc158db804ff097f2f--