Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:7608
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <5.1.0.14.2.20040205114425.02d1ec58@127.0.0.1>
Date: Thu, 05 Feb 2004 11:49:23 +0200
To: "Ananth Kesari" <hyanantha@novell.com>,<internals@lists.php.net>
In-Reply-To: <s021a495.015@prv-mail25.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; format=flowed
Subject: Re: [PHP-DEV] NetWare diff - 1.
From: andi@zend.com (Andi Gutmans)
References: <s021a495.015@prv-mail25.provo.novell.com>

Hi Ananth,

I'm sorry but your patches are kind of messy. There are far too many #ifdef 
NETWARE's in there. It should be possible to improve on this by creating 
abstraction for things such as stat.
I don't feel very comfortable with commiting them the way they are.
Has anyone else here looked at them?

Andi

At 02:03 AM 2/5/2004 -0700, Ananth Kesari wrote:
>Hi,
>
>Please find attached, the NetWare diff (text file) in the unified
>format taken using the command:  cvs diff -uN.
>
>When I attached the diff of the whole php5 project, my mails were
>bouncing. So, I have split it up manually and then sending the diff
>in two mails. The first part is attached below.
>
>Please let me know of your observations on this and if we can check
>this into the php5 sources. We can shoot to have these changes
>into the proposed Beta 4 for PHP5.
>
>Thanks,
>Ananth.
>
>
>--
>PHP Internals - PHP Runtime Development Mailing List
>To unsubscribe, visit: http://www.php.net/unsub.php