Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:7603
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Date: Wed, 4 Feb 2004 23:37:02 -0800 (Pacific Standard Time)
To: Jon Parise <jon@php.net>
cc: internals@lists.php.net
In-Reply-To: <20040205071733.GA26688@csh.rit.edu>
Message-ID: <Pine.WNT.4.56.0402042325490.2232@DELL>
References: <Pine.LNX.4.58.0402041517210.1449@thinkpad.lerdorf.com>
 <20040205071733.GA26688@csh.rit.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Subject: Re: [PHP-DEV] php-cgi command line switch memory check
From: rasmus@php.net (Rasmus Lerdorf)

On Thu, 5 Feb 2004, Jon Parise wrote:
> Some additional archaeology says that this logic goes back to PHP 3
> (main.c revision 1.354, from 5 years, 11 months ago):
>
>     http://cvs.php.net/diff.php/php3/main.c?login=2&r1=1.354&r2=1.355&ty=h
>
> I was kind of hoping it was something you had committed, but no such
> luck. =)

Well, it wouldn't have surprised me.  I hit this all the time.  I look at
code and wonder who the moron was who wrote it and just before sending out
a nastygram I doublecheck and find that I was that moron.

In this case the check was added by Jaakko Hyvatti in February 98.
Looking at the state of the code from back then I still don't see the
reason why those switches were disallowed when running in a web context.
We have to watch how we handle the query_string of course, but that
doesn't seem like a difficult problem to address.

-Rasmus