Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:76021
Return-Path: <johannes@schlueters.de>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 31025 invoked from network); 24 Jul 2014 16:14:10 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 24 Jul 2014 16:14:10 -0000
Authentication-Results: pb1.pair.com header.from=johannes@schlueters.de; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=johannes@schlueters.de; spf=permerror; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain schlueters.de from 217.114.215.10 cause and error)
X-PHP-List-Original-Sender: johannes@schlueters.de
X-Host-Fingerprint: 217.114.215.10 mail.experimentalworks.net  
Received: from [217.114.215.10] ([217.114.215.10:37686] helo=mail.experimentalworks.net)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 70/92-17249-FC031D35 for <internals@lists.php.net>; Thu, 24 Jul 2014 12:14:09 -0400
Received: by mail.experimentalworks.net (Postfix, from userid 1003)
	id ED9CB41695; Thu, 24 Jul 2014 18:14:13 +0200 (CEST)
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	km31408.keymachine.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=3.0 tests=ALL_TRUSTED
	autolearn=unavailable version=3.3.2
X-Spam-HAM-Report: 
	* -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
Received: from [192.168.2.31] (ppp-93-104-5-184.dynamic.mnet-online.de [93.104.5.184])
	(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	(Authenticated sender: johannes@schlueters.de)
	by mail.experimentalworks.net (Postfix) with ESMTPSA id 3C19341692;
	Thu, 24 Jul 2014 18:14:09 +0200 (CEST)
To: Dmitry Saprykin <saprykin.dmitry@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
In-Reply-To: <CAHWt7w3QoYid1Uv17LXUWVouW4zpLqymkd3TKUnUwtKwuRc4ng@mail.gmail.com>
References:
	 <CAHWt7w2PStjm4M4XqGeQeOi=vf_e7AT7jnESzhj=W3acckUhvw@mail.gmail.com>
	 <1405951255.3964.76.camel@guybrush>
	 <CAHWt7w15+xGL33jxej3MQ=EPV0jeG9ekEqKDx7x_DU1BBxO6Pw@mail.gmail.com>
	 <1406119104.3964.126.camel@guybrush>
	 <CAHWt7w3QoYid1Uv17LXUWVouW4zpLqymkd3TKUnUwtKwuRc4ng@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Date: Thu, 24 Jul 2014 18:13:19 +0200
Message-ID: <1406218399.3964.144.camel@guybrush>
Mime-Version: 1.0
X-Mailer: Evolution 2.30.3 
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] php interactive shell: save history on SIGINT exit
From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

On Wed, 2014-07-23 at 17:08 +0400, Dmitry Saprykin wrote:
> Yes, you are right. append_history is not suitable for libedit. I left
> write_history call for libedit.

Committed and pushed in a slightly modified form (variable declarations
should be on top of a block)
http://git.php.net/?p=php-src.git;a=commitdiff;h=d491b2f916d061666d9ff1cb5bdc484961b82db0

johannes