Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:75992 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 51311 invoked from network); 24 Jul 2014 07:13:29 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Jul 2014 07:13:29 -0000 Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.44 as permitted sender) X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.192.44 mail-qg0-f44.google.com Received: from [209.85.192.44] ([209.85.192.44:46804] helo=mail-qg0-f44.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 05/40-48436-812B0D35 for ; Thu, 24 Jul 2014 03:13:28 -0400 Received: by mail-qg0-f44.google.com with SMTP id e89so2786494qgf.17 for ; Thu, 24 Jul 2014 00:13:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=jetO7KZO4p1JNOKxp2IV0T/tlE4lawlkAqaNx9RIct8=; b=sGEm1tquCZRnB5g5Zs1N/wAftgtC5t9H1bLDslCjJWeYkHrLToy2cQXXMWUpfxZaz+ otPp4T5x/S1MUzdetzHWIXevRQOwfnFTbH+KNIpaMS19B50zBluktUf/A98x4jACua7I LC8HbSyIWVPZPJCVtEyOUyXkGLQp73e20LU5hYoP5vXJR6JrknNcufd50or2/ohSHLjK TukNTH3/rpLPPwTdUI4BApik9hu8pQlca+Oyoea2CMT1DcqcU+/5KFYvpMULpYKlpf2X 4Jfk+pZcGsdITPpoNyyeie5MmqvRdXeDIACyoHXvN6/G8fe939O4Hylt6gUra0NzQ7/4 SEwA== MIME-Version: 1.0 X-Received: by 10.224.12.138 with SMTP id x10mr9897319qax.36.1406186009118; Thu, 24 Jul 2014 00:13:29 -0700 (PDT) Received: by 10.140.24.54 with HTTP; Thu, 24 Jul 2014 00:13:29 -0700 (PDT) In-Reply-To: References: Date: Thu, 24 Jul 2014 09:13:29 +0200 Message-ID: To: Lonny Kapelushnik Cc: PHP internals Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: Deprecating GD functions imagettftext/bbox From: pierre.php@gmail.com (Pierre Joye) hi, On Tue, Jul 22, 2014 at 9:01 PM, Lonny Kapelushnik wro= te: > Morning, > > I propose deprecating two GD functions: imagettftext and imagettfbbox. > > The reasons I would like to deprecate them are: > 1. Their functionality is a subset of imagefttext and imageftbbox > 2. The imagettf* functions have the same requirements as the imageft* > functions > 3. The imagettf* functions parameters are compatible with the imageft* > functions parameters > > As far as I can tell the original reason for having both functions was > because PHP LIBGD is a custom implementation of LIBGD that had additional > functionality from the actual LIBGD. While this is still the case it seem= s > that now the required functions (gdImageStringFT and gdImageStringFTEx) > exist in both libraries. > > The only difference between imagettf* and imageft* functions is the > imagettf* functions do not provide the optional =E2=80=98extrainfo=E2=80= =99 parameter > > The only step to migrate from the imagettf* functions to imageft* functio= ns > is to change the function names from =E2=80=98imagettf*=E2=80=99 to =E2= =80=98imageft*' > > I would like to create a timeline to deprecate and remove the imagettf* > functions. Providing a timeline will allow for: > 1. Clarity for which PHP functions to use going forward > 2. Ability to plan a migration to the new PHP functions > 3. Clarity for which PHP functions to improve in php-src > 4. Ability to clean up some of the GD code in php-src > > I will hold off on proposing an actual timeline for now. > > I can implement any coding changes needed. > > Please let me know the general thoughts to deprecating these functions. I= f > the reception is positive I would like to create an RFC to discuss this = in > full and come up with a timeline. It is on my list to mark them as deprecated in the documentation. Also I am not sure it is worth the disagreement for the users to add notices or even to remove them as they both use the same underlying code. Basically there is no gain for us to actually remove them but yet another notice for the users. Cheers, --=20 Pierre @pierrejoye | http://www.libgd.org