Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:75957
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.44 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <1406119104.3964.126.camel@guybrush>
References: <CAHWt7w2PStjm4M4XqGeQeOi=vf_e7AT7jnESzhj=W3acckUhvw@mail.gmail.com>
 <1405951255.3964.76.camel@guybrush> <CAHWt7w15+xGL33jxej3MQ=EPV0jeG9ekEqKDx7x_DU1BBxO6Pw@mail.gmail.com>
 <1406119104.3964.126.camel@guybrush>
Date: Wed, 23 Jul 2014 17:08:42 +0400
Message-ID: <CAHWt7w3QoYid1Uv17LXUWVouW4zpLqymkd3TKUnUwtKwuRc4ng@mail.gmail.com>
To: =?UTF-8?Q?Johannes_Schl=C3=BCter?= <johannes@schlueters.de>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b67697c479f2a04fedc0b44
Subject: Re: [PHP-DEV] php interactive shell: save history on SIGINT exit
From: saprykin.dmitry@gmail.com (Dmitry Saprykin)

--047d7b67697c479f2a04fedc0b44
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Yes, you are right. append_history is not suitable for libedit. I left
write_history call for libedit.


On 23 July 2014 16:38, Johannes Schl=C3=BCter <johannes@schlueters.de> wrot=
e:

> On Mon, 2014-07-21 at 18:17 +0400, Dmitry Saprykin wrote:
> > changed "write_history" at the end to "append_history" after
> > each cli_is_valid_code.
> > Now it is -1 line, +1 line commit and completely looks like bug fix. )
>
> Have you tested with libedit? - A quick grep on my system shows no
> append_history() call, haven't checked further, though.
>
> johannes
>
>
>

--047d7b67697c479f2a04fedc0b44--