Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:75955
Return-Path: <tjerk.meesters@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 36471 invoked from network); 23 Jul 2014 12:54:46 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 23 Jul 2014 12:54:46 -0000
Authentication-Results: pb1.pair.com smtp.mail=tjerk.meesters@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=tjerk.meesters@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.178 as permitted sender)
X-PHP-List-Original-Sender: tjerk.meesters@gmail.com
X-Host-Fingerprint: 209.85.192.178 mail-pd0-f178.google.com  
Received: from [209.85.192.178] ([209.85.192.178:60912] helo=mail-pd0-f178.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 14/1B-21666-490BFC35 for <internals@lists.php.net>; Wed, 23 Jul 2014 08:54:45 -0400
Received: by mail-pd0-f178.google.com with SMTP id w10so1598424pde.9
        for <internals@lists.php.net>; Wed, 23 Jul 2014 05:54:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=content-type:mime-version:subject:from:in-reply-to:date:cc
         :content-transfer-encoding:message-id:references:to;
        bh=iAXkIE8e98N9uFFFT8FYbTx/4GmfonnBBqV+SwxpJvs=;
        b=mMaUQTkoJpitMLSkKjhfCFhlOf4Xx1kW+2Yb9BsqS8Rchqu7DJJ4+0ilHp/QUbU75S
         L+zvV9SAcZlLc9KD+A1OZ3J9vyT1wlfoersEmGudKbwJg1KUCzkisS4UcKAPHoizN9Fi
         l9qshtZHpivQl1wgYNaTnMvcHWsltvrS+oUUg4aCZ4+oqPzS24JbqLWeKG+WIaJvPPyB
         3ENvKXy4zGSuQJJbNAeD1vcFUCPDM66ka9ne8su/wgkT051aW+ebJmrtDkJ/i4yvsM8X
         cqVMhYKqc1H5wAWK3Pz235wgtfRICuRbM1PRn47N3KMzEaNIkX0VNrrlQeQwiFDFCFNZ
         7ZUw==
X-Received: by 10.70.95.196 with SMTP id dm4mr1391557pdb.158.1406120083668;
        Wed, 23 Jul 2014 05:54:43 -0700 (PDT)
Received: from [192.168.1.104] (bb121-7-198-24.singnet.com.sg. [121.7.198.24])
        by mx.google.com with ESMTPSA id fo2sm2333533pbb.53.2014.07.23.05.54.41
        for <multiple recipients>
        (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
        Wed, 23 Jul 2014 05:54:42 -0700 (PDT)
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
In-Reply-To: <1406119104.3964.126.camel@guybrush>
Date: Wed, 23 Jul 2014 20:54:38 +0800
Cc: Dmitry Saprykin <saprykin.dmitry@gmail.com>,
 PHP Internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <2DFB4645-5456-47CB-A4AA-B66738EAD773@gmail.com>
References: <CAHWt7w2PStjm4M4XqGeQeOi=vf_e7AT7jnESzhj=W3acckUhvw@mail.gmail.com> <1405951255.3964.76.camel@guybrush> <CAHWt7w15+xGL33jxej3MQ=EPV0jeG9ekEqKDx7x_DU1BBxO6Pw@mail.gmail.com> <1406119104.3964.126.camel@guybrush>
To: =?iso-8859-1?Q?Johannes_Schl=FCter?= <johannes@schlueters.de>
X-Mailer: Apple Mail (2.1878.6)
Subject: Re: [PHP-DEV] php interactive shell: save history on SIGINT exit
From: tjerk.meesters@gmail.com (Tjerk Meesters)


On 23 Jul, 2014, at 8:38 pm, Johannes Schl=FCter =
<johannes@schlueters.de> wrote:

> On Mon, 2014-07-21 at 18:17 +0400, Dmitry Saprykin wrote:
>> changed "write_history" at the end to "append_history" after
>> each cli_is_valid_code.
>> Now it is -1 line, +1 line commit and completely looks like bug fix. =
)
>=20
> Have you tested with libedit? - A quick grep on my system shows no
> append_history() call, haven't checked further, though.

Yes, compilation fails with libedit (mac):

Undefined symbols for architecture x86_64:
  "_append_history", referenced from:
      _readline_shell_run in readline_cli.o

>=20
> johannes
>=20
>=20
>=20
> --=20
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>=20