Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:75954 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 34418 invoked from network); 23 Jul 2014 12:39:14 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Jul 2014 12:39:14 -0000 Authentication-Results: pb1.pair.com header.from=johannes@schlueters.de; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=johannes@schlueters.de; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain schlueters.de from 217.114.215.10 cause and error) X-PHP-List-Original-Sender: johannes@schlueters.de X-Host-Fingerprint: 217.114.215.10 mail.experimentalworks.net Received: from [217.114.215.10] ([217.114.215.10:59902] helo=mail.experimentalworks.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A9/BA-21666-0FCAFC35 for ; Wed, 23 Jul 2014 08:39:14 -0400 Received: by mail.experimentalworks.net (Postfix, from userid 1003) id 1924941658; Wed, 23 Jul 2014 14:39:19 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on km31408.keymachine.de X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=ALL_TRUSTED autolearn=unavailable version=3.3.2 X-Spam-HAM-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP Received: from [192.168.2.31] (ppp-93-104-9-242.dynamic.mnet-online.de [93.104.9.242]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: johannes@schlueters.de) by mail.experimentalworks.net (Postfix) with ESMTPSA id B7F4B415E8; Wed, 23 Jul 2014 14:39:14 +0200 (CEST) To: Dmitry Saprykin Cc: PHP Internals In-Reply-To: References: <1405951255.3964.76.camel@guybrush> Content-Type: text/plain; charset="UTF-8" Date: Wed, 23 Jul 2014 14:38:24 +0200 Message-ID: <1406119104.3964.126.camel@guybrush> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] php interactive shell: save history on SIGINT exit From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=) On Mon, 2014-07-21 at 18:17 +0400, Dmitry Saprykin wrote: > changed "write_history" at the end to "append_history" after > each cli_is_valid_code. > Now it is -1 line, +1 line commit and completely looks like bug fix. ) Have you tested with libedit? - A quick grep on my system shows no append_history() call, haven't checked further, though. johannes